Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: Set suggested-namespace and related annotations #306

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Dec 5, 2024

Add a few annotations:

  • operatorframework.io/cluster-monitoring: "true"
  • operatorframework.io/suggested-namespace: "openshift-secondary-scheduler-operator"
  • console.openshift.io/operator-monitoring-default: "true" to simplify the deployment via OCP console.

@ingvagabund ingvagabund added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2024
@openshift-ci-robot
Copy link

@ingvagabund: This pull request explicitly references no jira issue.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

Add a few annotations:

  • operatorframework.io/cluster-monitoring: "true"
  • operatorframework.io/suggested-namespace: "openshift-kube-descheduler-operator"
  • console.openshift.io/operator-monitoring-default: "true" to simplify the deployment via OCP console.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund
Copy link
Member Author

/override ci/prow/e2e-aws-operator
/override ci/prow/images
/override ci/prow/security
/override ci/prow/unit
/override ci/prow/verify

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@ingvagabund: Overrode contexts on behalf of ingvagabund: ci/prow/e2e-aws-operator, ci/prow/images, ci/prow/security, ci/prow/unit, ci/prow/verify

In response to this:

/override ci/prow/e2e-aws-operator
/override ci/prow/images
/override ci/prow/security
/override ci/prow/unit
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ingvagabund ingvagabund merged commit 8e15ab3 into openshift:release-4.15 Dec 5, 2024
7 checks passed
@ingvagabund ingvagabund deleted the release-4.15 branch December 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants