Bug 1989122: Fix hybrid proxier with EndpointSlice#329
Bug 1989122: Fix hybrid proxier with EndpointSlice#329openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
The code was mistakenly assuming that an EndpointSlice would have the same name as its Service, rather than having a name *based on* its Service's name. Also, when HybridProxier gets OnEndpointSlicesSynced, it needs to send OnEndpointsSynced to the unidling proxy, not OnEndpointSlicesSynced.
danwinship
force-pushed
the
endpointslice-fixup
branch
from
a5cb690 to
6b3206b
Compare
danwinship
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @squeed |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, squeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danwinship
changed the title
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@danwinship: This pull request references Bugzilla bug 1989122, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@danwinship: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1989122 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 participants
The code was mistakenly assuming that an EndpointSlice would have the same name as its Service, rather than having a name based on its Service's name.
Also, when HybridProxier gets
OnEndpointSlicesSynced, it needs to sendOnEndpointsSyncedto the unidling proxy, notOnEndpointSlicesSynced.