Skip to content

Comments

Bug 1960284: Bump openshift/kubernetes for "local-with-fallback"#310

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:BZ1960284-bump-openshift-slash-kubernetes-for-local-with-fallback
Jun 2, 2021
Merged

Bug 1960284: Bump openshift/kubernetes for "local-with-fallback"#310
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Miciah:BZ1960284-bump-openshift-slash-kubernetes-for-local-with-fallback

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Jun 1, 2021

Bump the vendored openshift/kubernetes version in order to get support for the traffic-policy.network.alpha.openshift.io/local-with-fallback service annotation in kube-proxy.

  • go.mod: Bump openshift/kubernetes.
  • go.sum:
  • vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go:
  • vendor/modules.txt: Regenerate.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2021

@Miciah: This pull request references Bugzilla bug 1960284, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1960284: Bump openshift/kubernetes for "local-with-fallback"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2021
Bump the vendored openshift/kubernetes version in order to get support for
the "traffic-policy.network.alpha.openshift.io/local-with-fallback" service
annotation in kube-proxy.

This commit is related to bug 1960284.

https://bugzilla.redhat.com/show_bug.cgi?id=1960284

* go.mod: Bump openshift/kubernetes.
* go.sum:
* vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go:
* vendor/modules.txt: Regenerate.
@Miciah Miciah force-pushed the BZ1960284-bump-openshift-slash-kubernetes-for-local-with-fallback branch from fd403f1 to 39bc748 Compare June 1, 2021 20:12
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2021
@danwinship
Copy link
Contributor

/test unit
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d102132 into openshift:master Jun 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@Miciah: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1960284 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1960284: Bump openshift/kubernetes for "local-with-fallback"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants