Skip to content

WIP: UPSTREAM 96371: kube-proxy: fall back to node-local terminating endpoints for external traffic#223

Closed
Miciah wants to merge 11 commits intoopenshift:masterfrom
Miciah:UPSTREAM-96371-kube-proxy-terminating
Closed

WIP: UPSTREAM 96371: kube-proxy: fall back to node-local terminating endpoints for external traffic#223
Miciah wants to merge 11 commits intoopenshift:masterfrom
Miciah:UPSTREAM-96371-kube-proxy-terminating

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Nov 18, 2020

No description provided.

@andrewsykim @Miciah
endpointslice API: add accepting and terminating conditions
041ab0d 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
feature gate: add gate EndpointSliceTerminatingCondition
da4f6b4 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
endpointslice API: rename 'accepting' condition to 'serving' condition
055b5a1 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: update internal endpoints map with 'serving' and 'termina…
885ba98 
…ting' condition from EndpointSlice

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: health check server should only check ready endpoints
80b8ed6 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: iptables proxier should fall back to ready terminating en…
2a4f350 
…dpoints

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: ipvs proxer should fall back to ready terminating endpoints
e861a64 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: add iptables unit tests for handling ready terminating en…
8081de4 
…dpoints

Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@andrewsykim @Miciah
kube-proxy: add ipvs unit tests for handling ready terminating endpoints
88889e0 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign dcbw after the PR has been reviewed.
You can assign the PR to them by writing /assign @dcbw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Enable EndpointSlice feature gates
cdb00f9 
Enable feature gates related to EndpointSlice, for testing purposes.

* vendor/k8s.io/kubernetes/pkg/features/kube_features.go
(defaultKubernetesFeatureGates): Enable the EndpointSliceProxying and
EndpointSliceTerminatingCondition feature gates.
@Miciah
Add debug logging
5274798 
* vendor/k8s.io/kubernetes/pkg/proxy/endpointslicecache.go
(newEndpointSliceInfo): Log function input and output.
(endpointsMapFromEndpointInfo): Reduce logging level of debug output.
* vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go (syncProxyRules):
Log service names, endpoints, and chains.
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 25, 2020

@Miciah: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps 5274798 link /test verify-deps
ci/prow/e2e-gcp 5274798 link /test e2e-gcp
ci/prow/e2e-aws 5274798 link /test e2e-aws
ci/prow/e2e-aws-upgrade 5274798 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 23, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2021

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 25, 2021
@Miciah
Copy link
Contributor Author

Miciah commented Mar 31, 2021

Superseded by #271 and openshift/kubernetes#607.
/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 31, 2021

@Miciah: Closed this PR.

Details

In response to this:

Superseded by #271 and openshift/kubernetes#607.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhat abhat Awaiting requested review from abhat

@aojea aojea Awaiting requested review from aojea

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Miciah @openshift-ci-robot @openshift-merge-robot @openshift-bot @andrewsykim