Skip to content

Bug 1879607: bump-k8s-to-1.19.2#219

Closed
tssurya wants to merge 1 commit intoopenshift:masterfrom
tssurya:bump-k8s-to-1.19.2
Closed

Bug 1879607: bump-k8s-to-1.19.2#219
tssurya wants to merge 1 commit intoopenshift:masterfrom
tssurya:bump-k8s-to-1.19.2

Conversation

@tssurya
Copy link
Contributor

@tssurya tssurya commented Nov 11, 2020

This PR rebases sdn on k8sv1.19.2.
Also includes the upstream PR openshift/kubernetes@6e071b2

Part of SDN-1346

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Bugzilla bug 1879607, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1879607: bump-k8s-to-1.19.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 11, 2020
@tssurya tssurya force-pushed the bump-k8s-to-1.19.2 branch 2 times, most recently from 1c98afa to c13bf7f Compare November 11, 2020 16:26
@tssurya
Copy link
Contributor Author

tssurya commented Nov 11, 2020

/test verify-deps

@tssurya tssurya force-pushed the bump-k8s-to-1.19.2 branch 2 times, most recently from 6bcc58f to c6edc6b Compare November 11, 2020 18:51
@tssurya
Copy link
Contributor Author

tssurya commented Nov 11, 2020

/hold until all tests pass

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@tssurya
Copy link
Contributor Author

tssurya commented Nov 11, 2020

wtf! locally I don't see any of the errors seen on the ci/prow/verify-deps job.

< # sigs.k8s.io/yaml => sigs.k8s.io/yaml v1.2.0
ERROR: Content of 'vendor/' directory doesn't match 'go.mod' configuration and the overrides in 'deps.diff'!
Did you run go mod vendor?
If this is an intentional change (a carry patch) please update the 'deps.diff' using 'make update-deps-overrides'.
make: **** [verify-deps] Error 1

make has no right to swear I should be the one swearing -_- . Will take a look at this tomorrow,

@tssurya tssurya force-pushed the bump-k8s-to-1.19.2 branch 3 times, most recently from 1dbf538 to 578b8d0 Compare November 12, 2020 15:22
@tssurya
Copy link
Contributor Author

tssurya commented Nov 12, 2020

/test verify-deps

1 similar comment
@tssurya
Copy link
Contributor Author

tssurya commented Nov 12, 2020

/test verify-deps

@tssurya
Copy link
Contributor Author

tssurya commented Nov 13, 2020

/retest

@tssurya tssurya force-pushed the bump-k8s-to-1.19.2 branch 2 times, most recently from dbcb835 to 9531821 Compare November 13, 2020 19:01
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tssurya
To complete the pull request process, please assign rcarrillocruz after the PR has been reviewed.
You can assign the PR to them by writing /assign @rcarrillocruz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor Author

tssurya commented Nov 13, 2020

wtf! locally I don't see any of the errors seen on the ci/prow/verify-deps job.

< # sigs.k8s.io/yaml => sigs.k8s.io/yaml v1.2.0
ERROR: Content of 'vendor/' directory doesn't match 'go.mod' configuration and the overrides in 'deps.diff'!
Did you run go mod vendor?
If this is an intentional change (a carry patch) please update the 'deps.diff' using 'make update-deps-overrides'.
make: **** [verify-deps] Error 1

make has no right to swear I should be the one swearing -_- . Will take a look at this tomorrow,

ok this was happening because the ci-job was using golang 1.13 and I had 1.15.

@tssurya
Copy link
Contributor Author

tssurya commented Nov 16, 2020

/hold

@tssurya
Copy link
Contributor Author

tssurya commented Nov 16, 2020

gosh did I mess up metrics point healthcheck somewhere? Cluster in trouble May day: Warning Unhealthy 116s (x18 over 3m21s) kubelet, ci-ln-p3sg3qt-f76d1-mtk45-master-2 Readiness probe failed:

looking into this.

@tssurya
Copy link
Contributor Author

tssurya commented Nov 18, 2020

gosh did I mess up metrics point healthcheck somewhere? Cluster in trouble May day: Warning Unhealthy 116s (x18 over 3m21s) kubelet, ci-ln-p3sg3qt-f76d1-mtk45-master-2 Readiness probe failed:

looking into this.

had to update this patch to accommodate this change: kubernetes/kubernetes@8747ba9

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Bugzilla bug 1879607, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1879607: bump-k8s-to-1.19.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Bugzilla bug 1879607, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1879607: bump-k8s-to-1.19.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya
Copy link
Contributor Author

tssurya commented Nov 18, 2020

/test e2e-gcp

@tssurya
Copy link
Contributor Author

tssurya commented Nov 19, 2020

/retest

@tssurya
Copy link
Contributor Author

tssurya commented Nov 19, 2020

/test e2e-gcp

@tssurya
Copy link
Contributor Author

tssurya commented Nov 19, 2020

ok so the CI failures seem unrelated:
/cancel hold

@tssurya
Copy link
Contributor Author

tssurya commented Nov 19, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@tssurya
Copy link
Contributor Author

tssurya commented Nov 20, 2020

/retest

1 similar comment
@tssurya
Copy link
Contributor Author

tssurya commented Nov 22, 2020

/retest

@tssurya
Copy link
Contributor Author

tssurya commented Nov 23, 2020

/test e2e-aws

@tssurya
Copy link
Contributor Author

tssurya commented Nov 24, 2020

/test e2e-gcp

1 similar comment
@tssurya
Copy link
Contributor Author

tssurya commented Nov 24, 2020

/test e2e-gcp

@tssurya
Copy link
Contributor Author

tssurya commented Nov 25, 2020

/test e2e-gcp
/test e2e-aws

@tssurya
Copy link
Contributor Author

tssurya commented Nov 26, 2020

/retest

@tssurya
Copy link
Contributor Author

tssurya commented Nov 26, 2020

/hold

It seems like something is again wrong specific to this patch:

level=info msg=Cluster operator network Progressing is True with Deploying: DaemonSet "openshift-multus/network-metrics-daemon" is not available (awaiting 3 nodes)
level=info msg=DaemonSet "openshift-multus/multus-admission-controller" is not available (awaiting 3 nodes)

investigating....

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2020
@tssurya
Copy link
Contributor Author

tssurya commented Dec 1, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

@tssurya: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 274c4f3 link /test e2e-aws-upgrade
ci/prow/e2e-gcp 274c4f3 link /test e2e-gcp
ci/prow/e2e-aws 274c4f3 link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship danwinship mentioned this pull request Dec 4, 2020
@danwinship
Copy link
Contributor

obsoleted by #227 which updates to 1.20
/close

@openshift-ci-robot
Copy link
Contributor

@danwinship: Closed this PR.

Details

In response to this:

obsoleted by #227 which updates to 1.20
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@tssurya: This pull request references Bugzilla bug 1879607. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1879607: bump-k8s-to-1.19.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants