Skip to content

baremetal-coco: Updated PCCS handling #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

baremetal-coco: Updated PCCS handling #1155

merged 2 commits into from
Oct 29, 2025

Conversation

@pawelpros
Copy link
Contributor

@pawelpros pawelpros commented Oct 10, 2025

- How to verify it
Install with TDX using install.sh

- Description for the changelog

Updated PCCS deployment - separated secrets from standard values and moved ConfigMap to PCCS openshift image

@openshift-ci openshift-ci bot requested review from gkurz and wainersm October 10, 2025 12:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

Hi @pawelpros. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pawelpros pawelpros mentioned this pull request Oct 10, 2025
Merged
@pawelpros pawelpros force-pushed the pproskur/pccs-pr branch 3 times, most recently from 5ce10a7 to fcefa55 Compare October 15, 2025 13:26
bpradipt
bpradipt reviewed Oct 16, 2025
View reviewed changes
@pawelpros pawelpros force-pushed the pproskur/pccs-pr branch 4 times, most recently from 6b9880c to d6f708e Compare October 23, 2025 11:57
@pawelpros pawelpros force-pushed the pproskur/pccs-pr branch 3 times, most recently from 25aa393 to 7dfe191 Compare October 27, 2025 08:36
@pawelpros
Copy link
Contributor Author

pawelpros commented Oct 27, 2025

@bpradipt I confirm that this PR works fine on bare metal with replaced image

@bpradipt bpradipt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
mythi
mythi reviewed Oct 27, 2025
View reviewed changes
@pawelpros
Copy link
Contributor Author

pawelpros commented Oct 28, 2025

@gkurz, @bpradipt can we merge this ?

mythi
mythi approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

gkurz
gkurz reviewed Oct 28, 2025
View reviewed changes
@pawelpros pawelpros force-pushed the pproskur/pccs-pr branch 3 times, most recently from 082ec91 to 06a394e Compare October 28, 2025 14:25
@pawelpros @gkurz
baremetal-coco: Format pccs.yaml file
935950a 
Performed automatic reformat using Intellij

Signed-off-by: Pawel Proskurnicki <[email protected]>
@pawelpros @gkurz
baremetal-coco: Remove PCCS config map and replace with env variables
ede9ade 
PCCS config map replaced with environment variables approach available in recent version of PCCS image.
Secrets are now passed via secretRef defined in install.sh script.

Updated PCCS image is temporary solution until next official release.

Available image (0.2.4) was built based on commit :

openshift/confidential-compute-artifacts@249225b5

with included commit:

openshift/confidential-compute-artifacts@5dd67c19

Signed-off-by: Pawel Proskurnicki <[email protected]>
gkurz
gkurz approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR :

  • move the trivial re-formatting commit first
  • use full urls when referring to commits in another repo

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@gkurz
Copy link
Member

gkurz commented Oct 29, 2025

Konflux pipeline is asking for /ok-to-test even though the ok-to-test label is already set...

/ok-to-test

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

@pawelpros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gkurz gkurz merged commit fb5ec82 into openshift:devel Oct 29, 2025
7 checks passed
@pawelpros pawelpros deleted the pproskur/pccs-pr branch October 29, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkurz gkurz gkurz approved these changes

@bpradipt bpradipt bpradipt approved these changes

@wainersm wainersm Awaiting requested review from wainersm

+1 more reviewer

@mythi mythi mythi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gkurz gkurz

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pawelpros @gkurz @mythi @bpradipt