Refactor peerpods #1069
Merged
Refactor peerpods #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ wc -l controllers/openshift_controller.go 2764 controllers/openshift_controller.go The file is huge already. The peer-pods logic needs some heavy fixing that will require to add some more peer-pods specific code. Let's move peer-pods to a separate file. It will be easier to read and maintain. This is consistent with what we already do for other more recent features. This doesn't change behavior. Signed-off-by: Greg Kurz <[email protected]>
Consolidate the peer pods enablement code in a separate function. This doesn't change behavior. Signed-off-by: Greg Kurz <[email protected]>
Consolidate the peer pods disablement code in a separate function. For the sake of symmetry with enablePeerPods, name it disablePeerPods. The existing disablePeerPods is arbitrary renamed to disablePeerPodsMiscConfigs. Signed-off-by: Greg Kurz <[email protected]>
|
@gkurz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold so that people can review. |
openshift-ci
bot
added
the
do-not-merge/hold
beraldoleal
approved these changes
Sep 23, 2025
bpradipt
approved these changes
Sep 23, 2025
Pacho20
reviewed
Sep 25, 2025
gkurz
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactoring peer pods code to a separate file for easier maintenance.
Without the PR :
With the PR :
No change in behavior.