[WIP] OCPBUGS-1689: Router clear admitted status on label changes

[gcs278]

The router clears route admitted status for routes no longer selected by route or namespace labels. This is achieved by modifying the handling of Delete events across the plugins. It also introduces the use of the Error event to identify rejected routes, instead of relying solely on the Delete event. Additionally, the Status plugin now utilizes these redefined Delete events to clear route statuses.

This is a simplified (and arguably more elegant) redesign of openshift/cluster-ingress-operator#849, which added a new control loop in the ingress operator. This control loop watched every route and namespace update, attempting to detect label changes. If a namespace label changed, it would need to reconcile every route in that namespace.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-1689, which is invalid:

• expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

WIP: Having the router unadmit routes on namespace and router label changes. Simplified (and possibly more elegant) version of openshift/cluster-ingress-operator#849 which adds a new control loop in the ingress operator.

Needs lots of work, but currently is POC.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	732a954	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gcs278]

/hold
unit test is failing

[candita]

/assign @Miciah

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

Needs rebase and understanding the unit test failure

[gcs278]

This should be targeting a specific condition, not removing the entire ingress condition, unless perhaps there isn't any conditions left.

[gcs278]

I'll take that back. When a router unadmits a route, we should just clear the whole status.ingress object. So this is mostly fine.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-1689. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

The router clears route admitted status for routes no longer selected by route or namespace labels. This is achieved by modifying the handling of Delete events across the plugins. It also introduces the use of the Error event to identify rejected routes, instead of relying solely on the Delete event. Additionally, the Status plugin now utilizes these redefined Delete events to clear route statuses.

This is a simplified (and arguably more elegant) redesign of openshift/cluster-ingress-operator#849, which added a new control loop in the ingress operator. This control loop watched every route and namespace update, attempting to detect label changes. If a namespace label changed, it would need to reconcile every route in that namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

/reopen

[openshift-ci]

@gcs278: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-1689, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The router clears route admitted status for routes no longer selected by route or namespace labels. This is achieved by modifying the handling of Delete events across the plugins. It also introduces the use of the Error event to identify rejected routes, instead of relying solely on the Delete event. Additionally, the Status plugin now utilizes these redefined Delete events to clear route statuses.

This is a simplified (and arguably more elegant) redesign of openshift/cluster-ingress-operator#849, which added a new control loop in the ingress operator. This control loop watched every route and namespace update, attempting to detect label changes. If a namespace label changed, it would need to reconcile every route in that namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-1689. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

The router clears route admitted status for routes no longer selected by route or namespace labels. This is achieved by modifying the handling of Delete events across the plugins. It also introduces the use of the Error event to identify rejected routes, instead of relying solely on the Delete event. Additionally, the Status plugin now utilizes these redefined Delete events to clear route statuses.

This is a simplified (and arguably more elegant) redesign of openshift/cluster-ingress-operator#849, which added a new control loop in the ingress operator. This control loop watched every route and namespace update, attempting to detect label changes. If a namespace label changed, it would need to reconcile every route in that namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.