Skip to content

[release-4.5] Bug 1866454: Back port Remove initial haproxy template commitAndReload #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Aug 12, 2020
Merged

[release-4.5] Bug 1866454: Back port Remove initial haproxy template commitAndReload #167

openshift-merge-robot merged 2 commits into from
Aug 12, 2020

Conversation

@sgreene570
Copy link
Contributor

@sgreene570 sgreene570 commented Aug 7, 2020

Back port of #165 as per BZ 1866454.

/assign @Miciah

@sgreene570
Add new router failed reload counter metric
dc680b7 
If a router reload fails after a router pod becomes
ready, we need a way to alert cluster admins that
newly created route resources are not being applied
to the cluster.
@sgreene570
Remove premature router reload call at startup
ad0336b 
The first call to `commitAndReload` bypasses the rate limited
reload logic that also takes into account route sync status.
Removing this initial router reload call will prevent the router
from starting in a "routeless" state: that is, a state were
the router is running before it has begun watching route
resources.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2020

@sgreene570: This pull request references Bugzilla bug 1866454, which is invalid:

  • expected dependent Bugzilla bug 1861455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.5] Bug 1866454: Back port Remove initial haproxy template commitAndReload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@Miciah
Copy link
Contributor

Miciah commented Aug 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 9, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 9, 2020

@openshift-bot: This pull request references Bugzilla bug 1866454, which is invalid:

  • expected dependent Bugzilla bug 1861455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 11, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2020

@openshift-bot: This pull request references Bugzilla bug 1866454, which is invalid:

  • expected dependent Bugzilla bug 1861455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 12, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2020

@openshift-bot: This pull request references Bugzilla bug 1866454, which is invalid:

  • expected dependent Bugzilla bug 1861455 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link
Contributor Author

sgreene570 commented Aug 12, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2020

@sgreene570: This pull request references Bugzilla bug 1866454, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1861455 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1861455 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link
Contributor Author

sgreene570 commented Aug 12, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 12, 2020

@sgreene570: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit e3b9390 into openshift:release-4.5 Aug 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2020

@sgreene570: All pull requests linked via external trackers have merged: openshift/router#167. Bugzilla bug 1866454 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1866454: Back port Remove initial haproxy template commitAndReload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 12, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 12, 2020

@sgreene570: new pull request created: #171

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sgreene570 @openshift-ci-robot @Miciah @openshift-bot @openshift-cherrypick-robot @mrunalp @openshift-merge-robot