Skip to content

[WRKLDS-730] add dummy flags needed for a switch to library-go server and ControlerCommand#29

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
atiratree:add-dummy-flag
Jul 20, 2023
Merged

[WRKLDS-730] add dummy flags needed for a switch to library-go server and ControlerCommand#29
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
atiratree:add-dummy-flag

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Jul 19, 2023

this PR is required for hypershift tests to pass in openshift/hypershift#2674 before we add library-go changes #28

@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@ingvagabund ingvagabund added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@ingvagabund
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: atiratree, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 38d9ec8 and 2 for PR HEAD 36213e7 in total

@ingvagabund
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5710699 into openshift:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants