Skip to content

Add optional vSphere IPI tests for MCO #9702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 16, 2020
Merged

Add optional vSphere IPI tests for MCO #9702

openshift-merge-robot merged 1 commit into from
Jun 16, 2020

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jun 16, 2020 •
edited
Loading

Currently e2e-vsphere in MCO assumes UPI flow. This commit would use e2e-vsphere as IPI and e2e-vsphere-upi for UPI

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jun 16, 2020

/cc @jcpowermac @patrickdillon

@vrutkovs vrutkovs mentioned this pull request Jun 16, 2020
Merged
@jcpowermac
Copy link
Contributor

jcpowermac commented Jun 16, 2020

Thanks @vrutkovs
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 16, 2020 •
edited
Loading

Any reason to not name the other job e2e-vsphere-ipi?

add: we already have an existing e2e-metal-ipi job so would be consistent

@jcpowermac
Copy link
Contributor

jcpowermac commented Jun 16, 2020 •
edited
Loading

Any reason to not name the other job e2e-vsphere-ipi?

add: we already have an existing e2e-metal-ipi job so would be consistent

From what I understand the consistent naming is IPI does not have a suffix and UPI does -upi

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jun 16, 2020

We're using e2e-metal-ipi as there is no UPI counterpart. I'm fine with renaming it to IPI, although pattern of aws/gcp/azure job naming seems to fit better

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 16, 2020

We're using e2e-metal-ipi as there is no UPI counterpart. I'm fine with renaming it to IPI, although pattern of aws/gcp/azure job naming seems to fit better

fair enough. thanks for explaining.

/approve

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 16, 2020

just want to double check one more time
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, kikisdeliveryservice, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 16, 2020

ok just wanted to triple check we weren't accidentally triggering a thundering herd. looks good.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2020

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-vsphere 382e802 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.6/e2e-vsphere 382e802 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.7/e2e-vsphere 382e802 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-vsphere-upi 382e802 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.7/e2e-vsphere-upi 382e802 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-vsphere 382e802 link /test pj-rehearse
ci/prow/pj-rehearse 382e802 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3eee850 into openshift:master Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2020

@vrutkovs: Updated the following 12 configmaps:

  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.7.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.5-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.6-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.7-presubmits.yaml
Details

In response to this:

Currently e2e-vsphere in MCO assumes UPI flow. This commit would use e2e-vsphere as IPI and e2e-vsphere-upi for UPI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs deleted the mco-vsphere-ipi branch September 16, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @jcpowermac @kikisdeliveryservice @openshift-ci-robot @openshift-merge-robot