Skip to content

Conversation

@iamemilio
Copy link
Contributor

@iamemilio iamemilio commented May 7, 2020

CAPO needs at least go version 1.13 in order to support the verion of k8s.io/apimachinery that it needs. We need to backport openshift/cluster-api-provider-openstack#94 to 4.4, which means that the 4.4 release of CAPO needs to support golang 1.13

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@iamemilio
Copy link
Contributor Author

/retest

@iamemilio iamemilio force-pushed the openstack_go_version_1.3_CAPO branch from 4afe150 to 2963bfd Compare May 8, 2020 14:23
@iamemilio iamemilio force-pushed the openstack_go_version_1.3_CAPO branch from 2963bfd to fa8eac0 Compare May 8, 2020 14:30
@Fedosin
Copy link
Contributor

Fedosin commented May 8, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor

Fedosin commented May 8, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit fcfc00a into openshift:master May 8, 2020
@openshift-ci-robot
Copy link
Contributor

@iamemilio: Updated the following 3 configmaps:

  • ci-operator-4.4-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-api-provider-openstack-release-4.4.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-release-4.4.yaml
  • ci-operator-4.4-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-openstack-release-4.4.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-release-4.4.yaml
  • ci-operator-4.4-configs configmap in namespace ci at cluster build01 using the following files:
    • key openshift-cluster-api-provider-openstack-release-4.4.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-release-4.4.yaml
Details

In response to this:

CAPO needs at least go version 1.13 in order to support the verion of k8s.io/apimachinery that it needs. We need to backport openshift/cluster-api-provider-openstack#94 to 4.4, which means that the 4.4 release of CAPO needs to support golang 1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants