Integration tests for registry, replacing existing

[smarterclayton]

This adds a new pattern for reusing the openshift master for integration
style tests.

This is the last step to replacing all image-registry jobs with ci-operator.

Depended on openshift/image-registry#88

[0xmichalis]

needs an update

[0xmichalis]

either use /tmp/admin.kubeconfig or copy from the other container to the right place

[smarterclayton]

Using /tmp/shared consistently.

[0xmichalis]

Do you want this test to be triggered alongside the new?

[smarterclayton]

no, going to move to "old-integration" and then remove when it's truly gone.

[0xmichalis]

You were thinking about something

[smarterclayton]

Wanted a working directory for crap that wouldn't show up in artifacts or shared content.

[smarterclayton]

Updated, i think this is good to go.

[0xmichalis]

It seems that sidecar does not mount /tmp for artifacts but /logs. entrypoint also uses /logs/artifacts for ARTIFACTS even though COMMAND has the artifacts path you are using here (/tmp/artifacts). We probably want the sidecar to use the right path.

  - command:
    - /tools/entrypoint
    env:
    - name: COMMAND
      value: TEST_KUBECONFIG=${KUBECONFIG} ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=true
        make test-integration
    - name: CONFIG_SPEC
      valueFrom:
        configMapKeyRef:
          key: config.json
          name: ci-operator-image-registry
    - name: ARTIFACTS
      value: /logs/artifacts
    - name: BUILD_ID
      value: "999883142342905856"
    - name: BUILD_NUMBER
      value: "999883142342905856"
    - name: ENTRYPOINT_OPTIONS
      value: '{"args":["ci-operator","--delete-when-idle=10m","--artifact-dir=$(ARTIFACTS)","--dry-run=false","--template=/usr/local/integration","--target=integration"],"timeout":7200000000000,"grace_period":15000000000,"artifact_dir":"/logs/artifacts","process_log":"/logs/process-log.txt","marker_file":"/logs/marker-file.txt"}'
    - name: GOPATH
      value: /home/prow/go
    - name: JOB_NAME
      value: pull-ci-image-registry-integration
    - name: JOB_SPEC
      value: '{"type":"presubmit","job":"pull-ci-image-registry-integration","buildid":"999883142342905856","prowjobid":"74e42940-5fdb-11e8-99d8-7831c1b76042","refs":{"org":"openshift","repo":"image-registry","base_ref":"master","base_sha":"ff73b7f5a67f99fa406d2cd21a20714d189f7d2c","pulls":[{"number":82,"author":"smarterclayton","sha":"cd907c3"}]}}'
    - name: JOB_TYPE
      value: presubmit
    - name: PROW_JOB_ID
      value: 74e42940-5fdb-11e8-99d8-7831c1b76042
    - name: PULL_BASE_REF
      value: master
    - name: PULL_BASE_SHA
      value: ff73b7f5a67f99fa406d2cd21a20714d189f7d2c
    - name: PULL_NUMBER
      value: "82"
    - name: PULL_PULL_SHA
      value: cd907c3
    - name: PULL_REFS
      value: master:ff73b7f5a67f99fa406d2cd21a20714d189f7d2c,82:cd907c3
    - name: REPO_NAME
      value: image-registry
    - name: REPO_OWNER
      value: openshift
    image: docker-registry.default.svc:5000/ci/ci-operator@sha256:7eb706071d71b89dcac6f586fd7b6cdda82b3519cc75ac2d821d2ef655d914a1
    imagePullPolicy: Always
    name: test
    resources: {}
    securityContext:
      capabilities:
        drop:
        - KILL
        - MKNOD
        - SETGID
        - SETUID
      runAsUser: 1000130000
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /usr/local/integration
      name: job-definition
      subPath: master-sidecar.yaml
    - mountPath: /logs
      name: logs
    - mountPath: /home/prow/go
      name: code
    - mountPath: /tools
      name: tools
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: ci-operator-token-tbshg
      readOnly: true
    workingDir: /home/prow/go/src/github.com/openshift/image-registry
  - command:
    - /sidecar
    env:
    - name: JOB_SPEC
      value: '{"type":"presubmit","job":"pull-ci-image-registry-integration","buildid":"999883142342905856","prowjobid":"74e42940-5fdb-11e8-99d8-7831c1b76042","refs":{"org":"openshift","repo":"image-registry","base_ref":"master","base_sha":"ff73b7f5a67f99fa406d2cd21a20714d189f7d2c","pulls":[{"number":82,"author":"smarterclayton","sha":"cd907c3"}]}}'
    - name: SIDECAR_OPTIONS
      value: '{"gcs_options":{"items":["/logs/artifacts"],"bucket":"origin-ci-test","path_strategy":"single","default_org":"openshift","default_repo":"origin","gcs_credentials_file":"/secrets/gcs/service-account.json","dry_run":false},"wrapper_options":{"process_log":"/logs/process-log.txt","marker_file":"/logs/marker-file.txt"}}'
    image: registry.svc.ci.openshift.org/ci/sidecar:latest-json
    imagePullPolicy: IfNotPresent
    name: sidecar
    resources: {}
    securityContext:
      capabilities:
        drop:
        - KILL
        - MKNOD
        - SETGID
        - SETUID
      runAsUser: 1000130000
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /logs
      name: logs
    - mountPath: /secrets/gcs
      name: gcs-credentials
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: ci-operator-token-tbshg
      readOnly: true

[smarterclayton]

The core pod (ci operator) is writing to /logs/artifacts. That's now hardcoded in the test-infra (which I thought was weird)

The pods are definitely different.

[openshift-ci-robot]

@smarterclayton: Updated the config configmap from file cluster/ci/config/prow/config.yaml

Details

In response to this:

This adds a new pattern for reusing the openshift master for integration
style tests.

This is the last step to replacing all image-registry jobs with ci-operator.

Depended on openshift/image-registry#88

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.