Skip to content

prow/orc: add release branches to tide config - #84979

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:add-tide-config-orc
Sep 11, 2026
Merged

prow/orc: add release branches to tide config#84979
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
shiftstack:add-tide-config-orc

Conversation

@mandre

@mandre mandre commented Sep 11, 2026

Copy link
Copy Markdown
Member

openstack-resource-controller was onboarded with only main in its tide includedBranches. The tide-config-manager branching phase only updates repos that already have release branches, so ORC was skipped on every branching event since onboarding.

Add all existing release branches (4.19 through 5.2) so that tide can merge PRs on those branches, and so that tide-config-manager picks up ORC in future branching events.

Summary by CodeRabbit

  • Updates OpenStack Resource Controller CI configuration.
  • Adds release branches release-4.19 through release-5.2 to the Tide query.
  • Enables Tide to manage pull requests and future branching events on these branches.

openstack-resource-controller was onboarded with only main in its
tide includedBranches. The tide-config-manager branching phase only
updates repos that already have release branches, so ORC was skipped
on every branching event since onboarding.

Add all existing release branches (4.19 through 5.2) so that tide
can merge PRs on those branches, and so that tide-config-manager
picks up ORC in future branching events.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: eb9f6388-afe5-487f-b5b2-8ede48f577d5

📥 Commits

Reviewing files that changed from the base of the PR and between c670857 and cdfe4a1.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift/openstack-resource-controller/_prowconfig.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The Tide configuration now includes release-4.19 through release-5.2 alongside main.

Changes

Tide branch coverage

Layer / File(s) Summary
Add release branch queries
core-services/prow/02_config/openshift/openstack-resource-controller/_prowconfig.yaml
Tide query coverage now includes release-4.19 through release-5.2 in addition to main.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: neisw

Merge Risk: ⚪ Minimal · up to cdfe4

The release branches are added to Tide configuration as intended, so the change is ready to merge.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding release branches to the ORC Tide configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only _prowconfig.yaml. It adds static Tide branch names and contains no Ginkgo test declarations or test titles. Therefore, the check's failure conditions do not apply…
Test Structure And Quality ✅ Passed PASS: The custom check applies to changed Ginkgo test code. This pull request changes only one YAML configuration file, adding eight Tide branch entries. The diff contains no test files or Ginkgo cons…
Microshift Test Compatibility ✅ Passed PASS. The pull request changes only _prowconfig.yaml and adds eight Tide branch entries. It adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-incompatible assumptions. The cu…
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one YAML Tide configuration file. It adds release-4.19 through release-5.2 to includedBranches. It adds no Ginkgo tests or test code, so the SNO test compatibility …
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only the Prow Tide configuration file. It adds release branch names to includedBranches. It does not modify deployment manifests, operator code, controllers, or schedu…
Ote Binary Stdout Contract ✅ Passed The pull request changes only one YAML Tide configuration file. It adds release branch names to includedBranches; it adds no OTE binary code, suite setup, logging, or stdout writes. The OTE Binary S…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only one Prow YAML file. It adds eight release-branch names to Tide's includedBranches list. It adds no Ginkgo tests, networking code, IP addresses, URLs, image pulls, o…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only one YAML configuration file. The added lines contain release branch names only. The patch introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptograph…
Container-Privileges ✅ Passed The pull request changes only _prowconfig.yaml and adds eight includedBranches values under Tide. The diff introduces no container or Kubernetes privilege settings, including privileged, `hostPI…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only Tide YAML branch configuration. It adds eight public release-branch names and does not add or modify logging. No passwords, tokens, API keys, PII, session IDs, internal h…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mandre: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gryf gryf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2026
@dlaw4608

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlaw4608, gryf, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 77ab867 into openshift:main Sep 11, 2026
12 checks passed
@openshift-merge-bot
openshift-merge-bot Bot deleted the add-tide-config-orc branch September 11, 2026 12:07
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@mandre: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster core-ci using the following files:
    • key core-services-prow-02_config-openshift-openstack-resource-controller-_prowconfig.yaml using file core-services/prow/02_config/openshift/openstack-resource-controller/_prowconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-openstack-resource-controller-_prowconfig.yaml using file core-services/prow/02_config/openshift/openstack-resource-controller/_prowconfig.yaml
Details

In response to this:

openstack-resource-controller was onboarded with only main in its tide includedBranches. The tide-config-manager branching phase only updates repos that already have release branches, so ORC was skipped on every branching event since onboarding.

Add all existing release branches (4.19 through 5.2) so that tide can merge PRs on those branches, and so that tide-config-manager picks up ORC in future branching events.

Summary by CodeRabbit

  • Updates OpenStack Resource Controller CI configuration.
  • Adds release branches release-4.19 through release-5.2 to the Tide query.
  • Enables Tide to manage pull requests and future branching events on these branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants