CM-1225: Run tls-13 before Feature:TLSProfile e2e in tls-scanner

[arun717]

Summary

• Enable TLSAdherence (tls-13) before test-tls-profile on the cert-manager-operator tls-scanner job.
• Keep deploy-operand after the e2e so TrustManager is recreated for tls-scanner-run.

Why

#83643 moved test-tls-profile ahead of TrustManager deploy (to avoid AlreadyExists / AfterEach deleting the CR before the scanner). That also placed the e2e before tls-13.

Feature:TLSProfile patches apiserver.spec.tlsAdherence. That field is feature-gated; without tls-13 kube-apiserver drops it (unknown field "spec.tlsAdherence") and the spec times out waiting for operand TLS args.

Seen on openshift/cert-manager-operator#466:

• https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cert-manager-operator/466/pull-ci-openshift-cert-manager-operator-master-tls-scanner/2097205637761994752

Jira: https://redhat.atlassian.net/browse/CM-1225

Test plan

• /pj-rehearse pull-ci-openshift-cert-manager-operator-master-tls-scanner (or wait for merge, then /test tls-scanner on cert-manager-operator#466)
• Confirm test phase order is tls-13 → test-tls-profile → deploy-operand → tls-scanner-run
• Confirm tls-13 logs TLSAdherence enabled before the e2e starts

Summary by CodeRabbit

• Updated cert-manager-operator OpenShift CI tls-scanner jobs.
• Runs tls-13 before test-tls-profile.
• Preserves deploy-operand before tls-scanner-run so TrustManager is recreated before scanning.

[openshift-ci-robot]

@arun717: This pull request references CM-1225 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• Enable TLSAdherence (tls-13) before test-tls-profile on the cert-manager-operator tls-scanner job.
• Keep deploy-operand after the e2e so TrustManager is recreated for tls-scanner-run.

Why

#83643 moved test-tls-profile ahead of TrustManager deploy (to avoid AlreadyExists / AfterEach deleting the CR before the scanner). That also placed the e2e before tls-13.

Feature:TLSProfile patches apiserver.spec.tlsAdherence. That field is feature-gated; without tls-13 kube-apiserver drops it (unknown field "spec.tlsAdherence") and the spec times out waiting for operand TLS args.

Seen on openshift/cert-manager-operator#466:

• https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cert-manager-operator/466/pull-ci-openshift-cert-manager-operator-master-tls-scanner/2097205637761994752

Jira: https://redhat.atlassian.net/browse/CM-1225

Test plan

• /pj-rehearse pull-ci-openshift-cert-manager-operator-master-tls-scanner (or wait for merge, then /test tls-scanner on cert-manager-operator#466)
• Confirm test phase order is tls-13 → test-tls-profile → deploy-operand → tls-scanner-run
• Confirm tls-13 logs TLSAdherence enabled before the e2e starts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@arun717: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cert-manager-operator-master-tls-scanner	openshift/cert-manager-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 294c4445-85c3-4f4a-bde0-f8db122c2b51

📥 Commits

Reviewing files that changed from the base of the PR and between db8dc9e and 46f91a5.

📒 Files selected for processing (2)

• ci-operator/config/openshift-priv/cert-manager-operator/openshift-priv-cert-manager-operator-master.yaml
• ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The tls-13 test reference now runs earlier in the TLS scanner workflows for both standard and private cert-manager operator configurations.

Changes

TLS scanner test ordering

Layer / File(s)	Summary
Reorder tls-13 in both workflows ci-operator/config/openshift*/cert-manager-operator/*master.yaml	Moves tls-13 before test-tls-profile and removes its former later position.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 46f91

The TLS scanner workflows now run tls-13 before the TLS profile test while retaining operand deployment before the scanner run. No current merge-blocking risk remains.

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: running tls-13 before the Feature:TLSProfile e2e test in tls-scanner.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only the order of the static CI step reference tls-13 in two YAML files. The diff adds and removes - ref: tls-13; it does not change any Ginkgo It, Describe, `Co…
Test Structure And Quality	✅ Passed	PASS. The pull request changes only two CI YAML files. The diff moves the existing tls-13 step before test-tls-profile and leaves the referenced Ginkgo test implementation unchanged. It introduces…
Microshift Test Compatibility	✅ Passed	PASS — The pull request changes only two CI YAML files. The diff moves the existing tls-13 reference before test-tls-profile and removes its later reference; it adds no Ginkgo It(), Describe()…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The check is not applicable. The pull request changes only two CI YAML files and moves the existing tls-13 reference within the tls-scanner step order. It adds no It(), Describe(), Context()…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only two CI YAML files. The exact diff moves - ref: tls-13 within the tls-scanner test list. It adds no deployment manifest, operator code, controller code, or topol…
Ote Binary Stdout Contract	✅ Passed	PASS. The commit changes only two CI YAML files. Each change moves the existing tls-13 reference before test-tls-profile; it does not change an OTE binary or process-level Go code. The referenced …
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only two CI YAML files. The exact diff moves the existing tls-13 reference before test-tls-profile; it adds no Ginkgo test declarations, IPv4 literals, URLs, or exte…
No-Weak-Crypto	✅ Passed	PASS. The commit changes only the order of the tls-13 reference in two YAML test definitions. The resulting order is tls-13 → test-tls-profile → deploy-operand → tls-scanner-run. No MD5, SHA…
Container-Privileges	✅ Passed	PASS. The exact commit diff only moves the existing tls-13 reference in two CI step lists. It does not add privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation,…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request only moves the existing tls-13 reference in two YAML test sequences. The diff adds and removes no logging commands, credentials, tokens, passwords, PII, or customer data. The refere…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[bharath-b-rh]

/lgtm
/approve
/pj-rehearse ack

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arun717, bharath-b-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cert-manager-operator/OWNERS [bharath-b-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@arun717: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[arun717]

/pj-rehearse ack

[openshift-merge-bot]

@arun717: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.