setup assisted-installer version v2.55 - #84289
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe configurations now use ChangesAssisted pipeline updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates the assisted-installer v2.55 CI configuration and generated job metadata, which are already aligned; no actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only four CI YAML files. The changed values are static image tags ( Full details: Test Structure And QualityExplanation PASS: The pull request changes only six CI YAML files. The diff updates base image tags and CI test/job configuration, including skip filters and Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only CI YAML configuration and generated presubmit job YAML. The diff adds no Go, Python, JavaScript, or TypeScript test files, no Ginkgo declarations, and no unavailable MicroShift API references. The MicroShift Test Compatibility check is therefore not applicable. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only six CI YAML files. The diff updates base image tags and CI skip settings; it adds no Ginkgo test declarations and no test source files. Therefore, the SNO compatibility check has no new e2e test to assess. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The pull request changes only CI image references, test skip filters, and generated Prow job annotations. The diff adds no deployment manifests, operator/controller code, pod affinity, topology spread, node selectors, tolerations, replica counts, update strategies, or PDBs. The existing NUM_MASTERS test environment values are unchanged. Therefore, no listed topology scheduling constraint is introduced. Full details: Ote Binary Stdout ContractExplanation PASS: The commit changes only YAML configuration and generated Prow job files. It changes base image tags and test skip settings. It does not change Go or other binary source files, and the patch contains no process-level stdout writes or logging setup. Therefore, the PR does not introduce the stated OTE stdout contract violation. Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The pull request changes only CI YAML configuration and generated presubmit YAML. It adds no Ginkgo tests and introduces no IPv4 addresses, URL construction, public hosts, downloads, or registry access. The existing IPv6 test declarations are unchanged; the changes update internal base-image tags and test scheduling filters. Full details: No-Weak-CryptoExplanation PASS. The PR changes only CI YAML. The diff updates Full details: Container-PrivilegesExplanation PASS. The pull request changes six CI YAML files. The added settings are Full details: No-Sensitive-Data-In-LogsExplanation PASS. The PR changes only base-image tags, test scheduling filters, and generated job annotations. The added lines contain no logging, printing, debugging, or sensitive-data output. Existing CODECOV_TOKEN reads remain unchanged and are not emitted by the changed configuration. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #84393 |
2 participants
Summary by CodeRabbit
assisted-image-service,assisted-installer-agent,assisted-installer, andassisted-service.assisted-test-infraandassisted-test-infra-internalbase images frombackplane-5.0tobackplane-5.1.always_run: false.