Skip to content

fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup - #83883

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mgencur:remove_volume_snapshot_location
Sep 1, 2026
Merged

fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup#83883
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
mgencur:remove_volume_snapshot_location

Conversation

@mgencur

@mgencur mgencur commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Removes VolumeSnapshotLocation resource creation from OADP v2 setup step for hypershift, simplifying the configuration.

Related to discussion in this thread

Summary by CodeRabbit

The Hypershift Agent and AWS OADP CI setup no longer creates the unused VolumeSnapshotLocation resource. The setup retains BackupStorageLocation configuration and continues waiting for the required resources to become ready.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1c6c0f3a-3a0c-4ac3-b85e-e2f5c211e5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 3073dd4 and fab7d8d.

📒 Files selected for processing (2)
  • ci-operator/step-registry/hypershift/aws/oadp-setup/hypershift-aws-oadp-setup-commands.sh
  • ci-operator/step-registry/hypershift/mce/agent/oadp/v2/setup/hypershift-mce-agent-oadp-v2-setup-commands.sh
💤 Files with no reviewable changes (2)
  • ci-operator/step-registry/hypershift/aws/oadp-setup/hypershift-aws-oadp-setup-commands.sh
  • ci-operator/step-registry/hypershift/mce/agent/oadp/v2/setup/hypershift-mce-agent-oadp-v2-setup-commands.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The Hypershift OADP setup scripts no longer create or apply VolumeSnapshotLocation resources. The setup flow continues with BackupStorageLocation creation and readiness checks.

Changes

OADP setup simplification

Layer / File(s) Summary
Remove VolumeSnapshotLocation setup
ci-operator/step-registry/hypershift/aws/oadp-setup/hypershift-aws-oadp-setup-commands.sh, ci-operator/step-registry/hypershift/mce/agent/oadp/v2/setup/hypershift-mce-agent-oadp-v2-setup-commands.sh
Removes the VolumeSnapshotLocation manifests and oc apply commands, including AWS/Minio credentials and configuration.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to fab7d

This localized change removes unused OADP resource creation without any supplied indication of a current correctness, availability, security, or deployment risk; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: sjenning, avishayt

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only two shell setup scripts. The diff removes VolumeSnapshotLocation YAML and related echo commands, with no added or modified It, Describe, Context, When, or…
Test Structure And Quality ✅ Passed PASS: The pull request changes only two shell setup scripts. The exact diff removes VolumeSnapshotLocation manifest creation and adds no Ginkgo It blocks or test code. Therefore the stated require…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only two shell setup scripts. The diff removes VolumeSnapshotLocation creation and adds no Ginkgo tests or test declarations such as It(), Describe(), Context(),…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo tests. The verified diff contains only 35 deletions from two OADP setup shell scripts, and no added lines or test constructs such as It(), Describe(), Context(), …
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only two Bash setup scripts, as shown by the HEAD^..HEAD path diff. The patch removes velero.io/v1 VolumeSnapshotLocation creation and does not add or modify deploym…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only two shell setup scripts. The exact diff removes VolumeSnapshotLocation creation blocks and adds no code. No Go file, OTE entrypoint, suite setup, or stdout write …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The verified diff contains only 35 deletions from two OADP shell setup scripts, with zero additions. Therefore the IPv4 and external-connectivity condi…
No-Weak-Crypto ✅ Passed PASS: The PR only deletes VolumeSnapshotLocation manifests from the two setup scripts. The committed diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token compa…
Container-Privileges ✅ Passed PASS — The pull request only deletes two VolumeSnapshotLocation creation blocks. The exact diff contains no added privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowPrivilegeEscal…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request only removes the VolumeSnapshotLocation YAML blocks and their status messages from both setup scripts. It adds no logging, tracing, or output of passwords, tokens, API keys, P…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the unused VolumeSnapshotLocation resource from the Hypershift OADP setup.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only two shell setup scripts. The diff removes VolumeSnapshotLocation YAML and related echo commands, with no added or modified It, Describe, Context, When, or other test titles. The changed files contain no Ginkgo test declarations.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only two shell setup scripts. The exact diff removes VolumeSnapshotLocation manifest creation and adds no Ginkgo It blocks or test code. Therefore the stated requirements for test responsibility, test cleanup, test timeouts, assertion messages, and Ginkgo fixture consistency are not applicable to this change.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only two shell setup scripts. The diff removes VolumeSnapshotLocation creation and adds no Ginkgo tests or test declarations such as It(), Describe(), Context(), or When(). The MicroShift Test Compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo tests. The verified diff contains only 35 deletions from two OADP setup shell scripts, and no added lines or test constructs such as It(), Describe(), Context(), or When(). The SNO compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only two Bash setup scripts, as shown by the HEAD^..HEAD path diff. The patch removes velero.io/v1 VolumeSnapshotLocation creation and does not add or modify deployment manifests, operator code, controllers, replicas, anti-affinity, topology spread, node selectors, tolerations, or PDBs. The current scripts contain no topology-related scheduling constructs. Therefore, the custom check is not applicable and no stated failure condition is introduced.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only two shell setup scripts. The exact diff removes VolumeSnapshotLocation creation blocks and adds no code. No Go file, OTE entrypoint, suite setup, or stdout write changed. Existing shell echo commands are outside the OTE binary contract.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The verified diff contains only 35 deletions from two OADP shell setup scripts, with zero additions. Therefore the IPv4 and external-connectivity conditions in this check do not apply.

Full details: No-Weak-Crypto

Explanation

PASS: The PR only deletes VolumeSnapshotLocation manifests from the two setup scripts. The committed diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparisons. Existing credential handling and insecureSkipTLSVerify are unchanged and do not match the stated failure conditions.

Full details: Container-Privileges

Explanation

PASS — The pull request only deletes two VolumeSnapshotLocation creation blocks. The exact diff contains no added privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root/security-context configuration. The affected directories contain no related privilege settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request only removes the VolumeSnapshotLocation YAML blocks and their status messages from both setup scripts. It adds no logging, tracing, or output of passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Existing credential handling and trace controls are unchanged.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from avishayt and sjenning August 24, 2026 09:45
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2026
@mgencur

mgencur commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Setup failing due to https://redhat.atlassian.net/browse/OCPBUGS-112342 , need to re-run after merging the related PR with the fix.

@mgencur

mgencur commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

The backup-restore tests passed on Baremetal+Kubevirt, only a few conformance tests failed, which is unrelated
The Baremetal+Agent platform uses the same OADP setup. I was not able to start the bare metal mgmt cluster. There have been some infrastructure issues that should be resolved soon. But it is not necessary to run it here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 27, 2026
@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/hold

I will update this for AWS too because VolumeSnapshotLocation should not be required either.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2026
Removes VolumeSnapshotLocation resource creation from OADP v2 setup step
for hypershift, simplifying the configuration.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@mgencur
mgencur force-pushed the remove_volume_snapshot_location branch from 1507a88 to fab7d8d Compare August 27, 2026 07:13
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

Removed VolumeSnapshotLocation from AWS too. We use CSI snapshots and VSL is not required for that. It is only required for volume snapshots with older non-CSI setup.

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2026
@mgencur mgencur changed the title fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup for Agent/Kubevirt fix(hypershift): remove unused VolumeSnapshotLocation in OADP setup Aug 27, 2026
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 27, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.2-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.1-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.0-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.23-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.22-e2e-v2-aws-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.2-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.1-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.0-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.23-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.22-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.21-e2e-agent-connected-ovn-ipv4-metal-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.2-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.1-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-5.0-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.23-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.22-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.21-e2e-kubevirt-metal-ovn-backuprestore openshift/hypershift presubmit Registry content changed
periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-v2-aws-backuprestore N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-aws-backuprestore N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-5.0-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-v2-aws-backuprestore N/A periodic Registry content changed

A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-v2-aws-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

TODO: Update docs for AWS backup/restore if VolumeSnapshotLocation is not required (using CSI)

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-v2-aws-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur

mgencur commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jparrill

Copy link
Copy Markdown
Contributor

/retest-required

@mgencur

mgencur commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-v2-aws-backuprestore fab7d8d link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-v2-aws-backuprestore
ci/rehearse/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore fab7d8d link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-backuprestore

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mgencur

mgencur commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 1, 2026
@mgencur

mgencur commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

The AWS and Baremetal/Agent configurations fully passed. The KubeVirt one has one failure in conformance tests which is unrelated to backup/restore. This is ready for merging.

@jparrill jparrill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 13e5fbe into openshift:main Sep 1, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants