Skip to content

Conversation

@jcpowermac
Copy link
Contributor

With the terraform change the state names also changed.
Will follow up with an alternative method of gathering
ip addressing.

With the terraform change the state names also changed.
Will follow up with an alternative method of gathering
ip addressing.
@jcpowermac
Copy link
Contributor Author

cc: @sdodson

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-azure-upi 42e85e1 link /test pj-rehearse
ci/rehearse/openshift/cluster-version-operator/master/e2e-aws-upi 42e85e1 link /test pj-rehearse
ci/prow/pj-rehearse 42e85e1 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Apr 16, 2020

Won't the followup need to be compatible with both old and new given that this template is used across many versions/branches?

@jcpowermac
Copy link
Contributor Author

Yep. The idea I was just thinking about is to use govc and grab the ip from vmtools.

@sdodson
Copy link
Member

sdodson commented Apr 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7912f3f into openshift:master Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster api.ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
Details

In response to this:

With the terraform change the state names also changed.
Will follow up with an alternative method of gathering
ip addressing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants