Skip to content

Allow redhat-developer org members to abort/rerun RHDH Prow jobs - #83518

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
zdrapela:add-rhdh-rerun-auth
Aug 18, 2026
Merged

Allow redhat-developer org members to abort/rerun RHDH Prow jobs#83518
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
zdrapela:add-rhdh-rerun-auth

Conversation

@zdrapela

@zdrapela zdrapela commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Periodics for RHDH family repos cannot be aborted by org members today because they only match Deck repo: '*', which is limited to openshift/test-platform (and a few named users).
  • Add default_rerun_auth_configs entries only for RHDH repos that have Prow jobs and should get this ACL: rhdh, rhdh-plugin-export-overlays, and rhdh-test-instance.
  • Grants abort/rerun to redhat-developer org members and keeps openshift/test-platform.

Test plan

  • make prow-config (already run locally)
  • After merge, confirm Deck abort works while logged in as a redhat-developer org member on a pending RHDH periodic
  • Confirm openshift/test-platform members can still abort those jobs
  • Ask DPTP for /lgtm and /approve (#forum-ocp-testplatform if needed); OWNERS for this file are dptp

Add default_rerun_auth_configs entries for RHDH family repos so org
members (and openshift/test-platform) can abort and rerun periodics
from Deck, not only the catch-all test-platform ACL.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9f46ca9c-3bda-4c66-b0ce-dff8604398c0

📥 Commits

Reviewing files that changed from the base of the PR and between d6f0bb5 and 6e71282.

📒 Files selected for processing (1)
  • core-services/prow/02_config/_config.yaml
💤 Files with no reviewable changes (1)
  • core-services/prow/02_config/_config.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 9 remain after this review.


Walkthrough

The Prow configuration adds rerun authorization for three redhat-developer repositories. The redhat-developer organization and OpenShift test-platform team can authorize reruns.

Changes

Rerun authorization

Layer / File(s) Summary
Configure repository rerun authorization
core-services/prow/02_config/_config.yaml
Added authorization entries for rhdh, rhdh-plugin-export-overlays, and rhdh-test-instance. Each entry permits the redhat-developer organization and OpenShift test-platform team.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6e712

This localized configuration change grants the specified RHDH organization members abort and rerun access for the intended Prow jobs while retaining existing access; no actionable merge-blocking risk remains beyond normal checks and owner review.

Suggested reviewers: smg247, hector-vido

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML rerun ACL entries; it introduces no Ginkgo test titles or dynamic test-name construction.
Test Structure And Quality ✅ Passed The PR changes only core-services/prow/02_config/_config.yaml; the aggregate diff contains no Go test files or Ginkgo It blocks, so these test-quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed The diff changes only a Prow YAML ACL and adds no Ginkgo e2e tests or OpenShift API usage; MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The full PR diff changes only Prow YAML ACL entries and adds no Ginkgo e2e tests, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only Prow rerun-authorization YAML entries; it adds no deployment manifests, operators, controllers, replicas, affinity, node selectors, or other scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML rerun ACL entries; no OTE binary or process-level stdout write is introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The base-to-HEAD diff changes only one YAML ACL file (+21 lines) and adds no Ginkgo tests or network operations; the IPv6/disconnected test check is not applicable.
No-Weak-Crypto ✅ Passed The aggregate PR diff adds only YAML GitHub organization and team ACL entries for three repositories; it introduces no weak crypto, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The complete PR diff only adds Deck rerun authorization entries for three repositories; it introduces no privileged, host namespace, SYS_ADMIN, escalation, or root settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only Prow rerun authorization YAML entries; the diff adds no logging calls or sensitive data values.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: granting redhat-developer members abort and rerun access for RHDH Prow jobs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from hector-vido and smg247 August 17, 2026 10:09
Drop rhdh-operator, rhdh-chart, and software-templates; they have
prow plugin shards but no jobs under ci-operator/jobs.
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 17, 2026
Keep abort/rerun auth on rhdh, overlays, and test-instance only.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zdrapela: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zdrapela: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@zdrapela: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bear-redhat

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2026
@albarbaro

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albarbaro, bear-redhat, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 91c935d into openshift:main Aug 18, 2026
12 checks passed
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@zdrapela: Updated the following 2 configmaps:

  • config configmap in namespace ci at cluster core-ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
Details

In response to this:

Summary

  • Periodics for RHDH family repos cannot be aborted by org members today because they only match Deck repo: '*', which is limited to openshift/test-platform (and a few named users).
  • Add default_rerun_auth_configs entries only for RHDH repos that have Prow jobs and should get this ACL: rhdh, rhdh-plugin-export-overlays, and rhdh-test-instance.
  • Grants abort/rerun to redhat-developer org members and keeps openshift/test-platform.

Test plan

  • make prow-config (already run locally)
  • After merge, confirm Deck abort works while logged in as a redhat-developer org member on a pending RHDH periodic
  • Confirm openshift/test-platform members can still abort those jobs
  • Ask DPTP for /lgtm and /approve (#forum-ocp-testplatform if needed); OWNERS for this file are dptp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rubenvp8510 added a commit to rubenvp8510/release that referenced this pull request Sep 8, 2026
enable-qe-catalogsource-disconnected derives the QE optional-operators
index tag from the cluster's Kubernetes version, giving
aosqe-index:v1.29 for OCP 4.16. That image is no longer available, so
the copy to the mirror registry produces nothing and the step dies on
ImagePullBackOff. This has broken every periodic run of this job since
June.

The step gained a SKIP_QE_APP_REGISTRY parameter in openshift#83517, and openshift#83518
moved the check to after the mirror ICSP is created, so setting it
leaves the mirror infrastructure in place and only skips the QE
catalogsource. That is a better fit here than pointing OO_INDEX at
another index, since this job does not need the QE catalog at all:
Tempo and OTEL come from cs-tempo and cs-otel, built from the index
images above.

amq-streams was the only operator sourced from the QE catalog, and none
of the five tests in tests/e2e-disconnected use Kafka, so it is dropped
from OPERATORS.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants