Allow redhat-developer org members to abort/rerun RHDH Prow jobs - #83518
Conversation
Add default_rerun_auth_configs entries for RHDH family repos so org members (and openshift/test-platform) can abort and rerun periodics from Deck, not only the catch-all test-platform ACL.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 12 reviews per rolling hour; 9 remain after this review. WalkthroughThe Prow configuration adds rerun authorization for three ChangesRerun authorization
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized configuration change grants the specified RHDH organization members abort and rerun access for the intended Prow jobs while retaining existing access; no actionable merge-blocking risk remains beyond normal checks and owner review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Drop rhdh-operator, rhdh-chart, and software-templates; they have prow plugin shards but no jobs under ci-operator/jobs.
Keep abort/rerun auth on rhdh, overlays, and test-instance only.
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 similar comment
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@zdrapela: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro, bear-redhat, zdrapela The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@zdrapela: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
enable-qe-catalogsource-disconnected derives the QE optional-operators index tag from the cluster's Kubernetes version, giving aosqe-index:v1.29 for OCP 4.16. That image is no longer available, so the copy to the mirror registry produces nothing and the step dies on ImagePullBackOff. This has broken every periodic run of this job since June. The step gained a SKIP_QE_APP_REGISTRY parameter in openshift#83517, and openshift#83518 moved the check to after the mirror ICSP is created, so setting it leaves the mirror infrastructure in place and only skips the QE catalogsource. That is a better fit here than pointing OO_INDEX at another index, since this job does not need the QE catalog at all: Tempo and OTEL come from cs-tempo and cs-otel, built from the index images above. amq-streams was the only operator sourced from the QE catalog, and none of the five tests in tests/e2e-disconnected use Kafka, so it is dropped from OPERATORS. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWrVkBmYnGwnuSfaK6d1cK
Summary
repo: '*', which is limited toopenshift/test-platform(and a few named users).default_rerun_auth_configsentries only for RHDH repos that have Prow jobs and should get this ACL:rhdh,rhdh-plugin-export-overlays, andrhdh-test-instance.redhat-developerorg members and keepsopenshift/test-platform.Test plan
make prow-config(already run locally)redhat-developerorg member on a pending RHDH periodicopenshift/test-platformmembers can still abort those jobs/lgtmand/approve(#forum-ocp-testplatformif needed); OWNERS for this file aredptp