Revert "Merge pull request #8314" #8340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62ccb9e, reversing changes made to 16bc9d3 by running `git revert -m 1 62ccb9e`. Reverting this to move back to using templates until we figure out openshift#8323.
openshift-ci-robot
added
the
approved
Contributor
Author
|
/cc @openshift/openshift-team-windows-containers |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aravindhp, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sebsoto
reviewed
Apr 15, 2020
| command: | ||
| - ci-operator | ||
| env: | ||
| - name: CLUSTER_TYPE |
Contributor
There was a problem hiding this comment.
Why is this not present in the 4.5 job?
Contributor
Author
There was a problem hiding this comment.
Because we never added it there in the first place
Contributor
|
lgtm |
1 similar comment
Member
|
lgtm |
Contributor
|
@aravindhp: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/test pj-rehearse |
Contributor
|
@aravindhp: Updated the following 15 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 62ccb9e, reversing changes made to 16bc9d3 by running
git revert -m 1 62ccb9e58.Reverting this to move back to using templates until we figure out #8323.