Disable 5.0 ipsec 120/252 node jobs and add ipsec 24-node job - #83216
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe AWS 5.0 nightly configuration adds a scheduled 24-node control-plane IPsec job and disables automatic execution for the existing 120-node and 252-node IPsec jobs. ChangesAWS PerfScale IPsec scheduling
Estimated code review effort: 1 (Trivial) | ~4 minutes Merge Risk: ⚪ Minimal · up to This change disables the 120-node and 252-node IPsec jobs and adds a scheduled 24-node IPsec job in the 5.0 nightly configuration. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes only CI configuration and generated Prow job files. The diff contains no Ginkgo test-title calls such as Full details: Test Structure And QualityExplanation PASS: The pull request changes only YAML configuration and generated CI job files. The diff adds the Full details: Microshift Test CompatibilityExplanation The check is not applicable. The PR changes only three YAML CI configuration files. The PR range adds no Go files and no Ginkgo declarations such as Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds and changes CI YAML job configuration only. The aggregate diff from the configuration commit through HEAD contains three modified Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — the pull request changes only CI-operator configuration and generated Prow job YAML. It adds a scheduled test job, changes test environment variables, and disables two schedules. The diff adds no deployment manifest, operator code, controller, pod scheduling constraint, node selector, affinity, topology spread, replica, or PDB declaration. The topology-aware scheduling check is therefore not applicable. Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only three YAML files: one 5.0 job configuration and two generated Prow job files. The diff adds or disables scheduled jobs and environment values. It contains no OTE binary source, suite setup, logging, or stdout write. Therefore, it introduces no failure under the OTE Binary Stdout Contract. Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The aggregate diff changes only one CI configuration YAML file and two generated job YAML files. The added 24-node job references existing chains and workflows, so this check finds no introduced IPv4 assumption or external connectivity requirement. Full details: No-Weak-CryptoExplanation PASS — The PR changes only three YAML files. The new job references the existing Full details: Container-PrivilegesExplanation PASS. The PR adds the 24-node job and disables the 120/252-node schedules. The changed config and generated Prow job files contain no Full details: No-Sensitive-Data-In-LogsExplanation PASS. The diff changes only YAML job configuration and generated Prow job definitions. The added job sets scheduling, workflow, and non-sensitive environment values such as ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse ack |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| ADDITIONAL_WORKER_NODES: "21" | ||
| BASE_DOMAIN: perfscale.devcluster.openshift.com | ||
| ENABLE_LAYER_3: "false" | ||
| KB_FLAGS: --local-indexing |
There was a problem hiding this comment.
Sync up flags from 120node job (CD_V2_EXTRA_FLAGS, KB_FLAGS, NODE_DENSITY_GC)
|
@mohit-sheth, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
5f03a7f to
0ced526
Compare
0ced526 to
9a99edc
Compare
|
/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes |
|
@afcollins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test config |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ad8e6af to
0cbe272
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
- control-plane-ipsec-120nodes: disable (set always_run: false) - control-plane-ipsec-252nodes: disable (set always_run: false) - control-plane-ipsec-24nodes: new 24-node ipsec job on aws-perfscale, 2x/month (11th, 23rd), with flags synced from the 120-node job Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
…24nodes Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
…ring Ensures Orion queries filter for ipsec=true data instead of the default false, matching the IPSec job's ES metadata. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
Move pod-node map refresh inside the polling loop so respawned IPsec pods are detected. Use custom-columns instead of -o wide for reliable node name extraction. Assisted-by: Claude Signed-off-by: Mohit Sheth <msheth@redhat.com>
0cbe272 to
76560be
Compare
|
/pj-rehearse periodic-ci-openshift-eng-ocp-perfscale-main-aws-5.0-nightly-x86-control-plane-ipsec-24nodes |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 292 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohit-sheth, mukrishn, rsevilla87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7bb4359
into
openshift:main
Summary
always_run: false)always_run: false)aws-perfscale, 2x/month (11th, 23rd), based on the 120-node config adapted for small scaleAll changes in the 5.0 nightly config only.
Summary by CodeRabbit
aws-perfscale.ORION_ENVS: ipsec=true.