Skip to content

Inject AWS IAM SetSecurityGroups perm on upgrades to 4.23 #82862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 4, 2026
Merged

Inject AWS IAM SetSecurityGroups perm on upgrades to 4.23 #82862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...openshift/upgrade/aws/patch-master-iam/openshift-upgrade-aws-patch-master-iam-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,24 @@ export KUBECONFIG="${SHARED_DIR}/kubeconfig"

SOURCE_VERSION=$(oc get clusterversion version -o jsonpath='{.status.desired.version}')
SOURCE_MAJOR=$(echo "${SOURCE_VERSION}" | cut -d. -f1)
SOURCE_MINOR=$(echo "${SOURCE_VERSION}" | cut -d. -f2)

TARGET_VERSION=$(oc adm release info "${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE:-}" \
--output=json 2>/dev/null | jq -r '.metadata.version') || {
echo "WARNING: could not determine target version, skipping patch."
exit 0
}
TARGET_MAJOR=$(echo "${TARGET_VERSION}" | cut -d. -f1)
TARGET_MINOR=$(echo "${TARGET_VERSION}" | cut -d. -f2)

if [[ "${SOURCE_MAJOR}" != "4" || "${TARGET_MAJOR}" != "5" ]]; then
echo "Not a 4.x to 5.x upgrade (${SOURCE_VERSION} to ${TARGET_VERSION}), skipping."
echo "Detected upgrade from ${SOURCE_VERSION} to ${TARGET_VERSION}, determining eligibility."
if [[ "${SOURCE_MAJOR}" != "4" || "${SOURCE_MINOR}" -gt 22 ]] || \
! [[ "${TARGET_MAJOR}" == "5" || ( "${TARGET_MAJOR}" == "4" && "${TARGET_MINOR}" == "23" ) ]]; then
echo "Not an upgrade from version <=4.22 to 4.23/5.x, skipping."
exit 0
fi

echo "Detected 4.x to 5.x upgrade (${SOURCE_VERSION} to ${TARGET_VERSION}), patching master IAM role."
echo "Detected upgrade from version <=4.22 to 4.23/5.x (${SOURCE_VERSION} to ${TARGET_VERSION}), patching master IAM role."

export AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred"
REGION="${LEASED_RESOURCE}"
Expand Down