OSAC-3504: Onboard osac-project/osac - #82745
Conversation
WalkthroughAdded Prow configuration for ChangesOSAC Prow configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@eliorerz: This pull request references OSAC-3504 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, oourfali The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@eliorerz: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
osac-project/osac is a new mono-repo consolidating three existing OSAC components (fulfillment-service, osac-operator, osac-aap have already been merged into it; more are planned). It currently has no Prow config in this repo at all -- no
tide/lgtm/approve/jira-lifecycle-plugingating -- unlike every other repo in the org, including the very standalone repos it's replacing.Adds
core-services/prow/02_config/osac-project/osac/{_prowconfig.yaml,_pluginconfig.yaml,OWNERS}, mirroringosac-operator's existing config with the repo name substituted (verifiedfulfillment-service/osac-operator/osac-aapall use an identical pattern, so there's nothing component-specific to reconcile).OWNERSis seeded fromosac-project/osac's current root OWNERS, with non-openshift-org-member logins filtered out to match how the existing per-repo OWNERS files here are generated.Verified
core-services/jira-lifecycle-plugin/config.yamlalready coversosac-projectvia an org-wide wildcard (repos: '*'), so no per-repo Jira project config is needed there.Ran
make prow-config(determinize-prow-config) locally against these new files -- zero diff, confirming they're already in canonical generated form.One open question for reviewers: does onboarding a repo this way (hand-authored config mirroring an existing sibling) fully cover everything a brand-new repo needs, or does a repo also require webhook/GitHub App provisioning that the interactive
make new-repo(repo-init) tool would normally set up and that this PR doesn't touch?osac-project/osacisn't entirely new to GitHub (it's been live for a while), but I want to confirm rather than assume this PR alone is sufficient to produce live gating.Summary by CodeRabbit
Adds Prow configuration to onboard
osac-project/osacinto OpenShift CI. The configuration defines repository ownership, approval and LGTM policies, Jira validation, Tide gating, plugins, and trusted trigger applications.The configuration mirrors the existing
osac-operatorsetup and uses repository-specific ownership.make prow-configproduced no diff after generation.