AUTOSCALE-890: Add tls scanner test step to CRO E2Es - #82176
Conversation
openshift-ci
Bot
added
the
approved
|
@joelsmith, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe CI configuration adds a TLS scanner image and updates the ChangesTLS scanner integration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant E2E as e2e-aws-olm
participant OC as oc
participant CRO as ClusterResourceOverride
participant Scanner as tls-scanner-run
E2E->>OC: Apply ClusterResourceOverride
OC->>CRO: Wait for Available condition
E2E->>Scanner: Run TLS scan with configured settings
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml`:
- Line 98: Fix the YAML structure around the deploy-operand entry: align
deploy-operand with the mapping keys under test (including cluster_profile and
workflow), or consistently convert steps to a list, so the job parses correctly
while preserving the intended test workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 131accf8-dff2-4f92-a7c0-fc6c2714379e
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml
|
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm,pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-operator |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@joelsmith: job(s): pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm,pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-operator either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-operator |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
joelsmith
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@joelsmith: This pull request references AUTOSCALE-890 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml`:
- Around line 105-117: Update both command blocks at
ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml
lines 105-117 and 147-159 to use oc apply instead of oc create, then wait for
the ClusterResourceOverride reconciliation and operand pod rollout to complete
before the deploy-operand step exits. Ensure both sites block until the pods are
ready for the subsequent tls-scanner-run step.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8301be0b-f7be-4355-8651-0b68562af537
📒 Files selected for processing (1)
ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml
|
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-operator |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
0fd667c to
df3b6ae
Compare
|
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@joelsmith: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@joelsmith: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think we can ignore the failure message from |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, shyadav10 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![openshift-prow[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
3 participants
Summary by CodeRabbit
This updates the OpenShift CI configuration for the Cluster Resource Override Admission Operator to add TLS scanner coverage to its AWS CRO end-to-end test flow. In
ci-operator/config/openshift/cluster-resource-override-admission-operator/openshift-cluster-resource-override-admission-operator-main.yaml, it introduces atls-scanner-toolbase image and extends thee2e-aws-olmworkflow to:SCAN_NAMESPACE=openshift-cluster-resource-override,PQC_CHECK, and scanner CPU/memory limits),ClusterResourceOverrideoperand into the cluster viaoc apply,clusterresourceoverride/clusterto reachAvailable(5m timeout), and thentls-scanner-runstep against the configured namespace.