OPNET-779: kube-vip: build the image and promote to ocp/5.0 - #81957
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mkowalski: This pull request references OPNET-779 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe OpenShift kube-vip CI configuration adds image publishing, release promotion, 5.0 integration lanes, build-root and test settings, resource defaults, and generated branch metadata. Changeskube-vip OpenShift CI
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse max |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/kube-vip/openshift-kube-vip-release-5.0.yaml`:
- Around line 32-35: Remove the test_binary_build_commands entry from the
kube-vip release configuration, including its go test -race ./... command. Keep
the existing unit-tests entry and its make unit-tests command unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d9f6421d-8f9a-4f30-94b6-c110161a2455
⛔ Files ignored due to path filters (4)
ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-release-5.0-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/kube-vip/openshift-kube-vip-main.yamlci-operator/config/openshift/kube-vip/openshift-kube-vip-release-5.0.yaml
fd5fd78 to
617f776
Compare
|
/pj-rehearse ack |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@mkowalski, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
758f346 to
ec2cdbf
Compare
openshift-ci
Bot
added
needs-rebase
|
@mkowalski, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 similar comment
|
@mkowalski, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
709f237 to
4b8345b
Compare
openshift-ci
Bot
removed
the
approved
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
/pj-rehearse max |
|
@mkowalski: your |
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
|
/lgtm |
|
@mkowalski: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
|
/lgtm |
The kube-vip onboarding was test-only: no images stanza and no promotion, so CI never builds the container, the private-org sync and the release branching automation ignore the repo, and no release-5.0 branch is ever created. This blocks the ART payload onboarding (ART-21663, OPNET-779): MCO's image-references will reference the kube-vip payload tag (OPNET-782). Add the image build (Dockerfile.openshift) and promotion to ocp/5.0 on main, plus the release-5.0 config with promotion disabled per the pre-branch-cut convention (modeled on baremetal-runtimecfg). Signed-off-by: Mat Kowalski <mko@redhat.com>
3ed667c to
5d6919b
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, mkowalski, rbbratta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
332d459
into
openshift:main
The kube-vip onboarding was test-only: no images stanza and no promotion, so CI never builds the container, the private-org sync and the release branching automation ignore the repo, and no release-5.0 branch is ever created. This blocks the ART payload onboarding (ART-21663, OPNET-779): MCO's image-references will reference the kube-vip payload tag (OPNET-782). Add the image build (Dockerfile.openshift) and promotion to ocp/5.0 on main, plus the release-5.0 config with promotion disabled per the pre-branch-cut convention (modeled on baremetal-runtimecfg). Signed-off-by: Mat Kowalski <mko@redhat.com>
The kube-vip onboarding was test-only: no images stanza and no promotion, so CI never builds the container, the private-org sync and the release branching automation ignore the repo, and no release-5.0 branch is ever created. This blocks the ART payload onboarding (ART-21663, OPNET-779): MCO's image-references will reference the kube-vip payload tag (OPNET-782). Add the image build (Dockerfile.openshift) and promotion to ocp/5.0 on main, plus the release-5.0 config with promotion disabled per the pre-branch-cut convention (modeled on baremetal-runtimecfg). Signed-off-by: Mat Kowalski <mko@redhat.com>
Split from the previous commit on purpose: nightly payload assembly fails on an image-references entry whose tag does not exist, so this lands only after the kube-vip image is onboarded (ART-21663, openshift/release#81957).
|
@openshift/test-platform The kube-vip promotion from this PR does not seem to have reached the ocp/5.0 integration stream: the This comment was written with AI assistance. Please verify before acting on it. |
![openshift-prow[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
The kube-vip onboarding was test-only: no images stanza and no promotion, so CI never builds the container, the private-org sync and the release branching automation ignore the repo, and no release-5.0 branch is ever created. This blocks the ART payload onboarding (ART-21663, OPNET-779): MCO's image-references will reference the kube-vip payload tag (OPNET-782). Add the image build (Dockerfile.openshift) and promotion to ocp/5.0 on main, plus the release-5.0 config with promotion disabled per the pre-branch-cut convention (modeled on baremetal-runtimecfg). Signed-off-by: Mat Kowalski <mko@redhat.com>
The kube-vip onboarding was test-only: no images stanza and no promotion, so CI never builds the container, the private-org sync and the release branching automation ignore the repo, and no release-5.0 branch is ever created. This blocks the ART payload onboarding (ART-21663, OPNET-779): MCO's image-references will reference the kube-vip payload tag (OPNET-782). Add the image build (Dockerfile.openshift) and promotion to ocp/5.0 on main, plus the release-5.0 config with promotion disabled per the pre-branch-cut convention (modeled on baremetal-runtimecfg). Signed-off-by: Mat Kowalski <mko@redhat.com>
4 participants
What
Completes the openshift/kube-vip CI onboarding, which was test-only:
imagesstanza (Dockerfile.openshift →kube-vip) so CI actually builds the containerpromotiontoocp/5.0onmain(+releasesintegration streams)release-5.0config with promotiondisabled: trueper the pre-branch-cut convention (modeled on openshift/baremetal-runtimecfg)make updateWhy
Without promotion the repo is invisible to the private-org sync and the release branching automation — no
openshift-priv/kube-vipmirror and norelease-5.0branch is ever created — and the nightly payload has nokube-viptag to consume.This unblocks the ART payload onboarding ART-21663 (Jira: OPNET-779, parent OPNET-595 — BGP-based VIP management, feature gate
BGPBasedVIPManagement). Ordering constraint: this + ART-21663 must land before openshift/machine-config-operator's image-references change (OPNET-782) references thekube-vippayload tag.Summary by CodeRabbit
openshift/kube-vipto OpenShift CI by defining CI config that builds the component fromDockerfile.openshiftand publishes the result as thekube-vipimage (using theopenshift/rhel-9-release-golang-1.26-openshift-5.0build root).mainstream to promote and release-integrate the5.0lane into theocpnamespace, with thelatestlane including built images so thekube-viptag appears in nightly payloads.release-5.0CI configuration for therelease-5.0branch, including the same build/publish mapping, while explicitly disabling promotion to the"5.0"target until the release branch cut.make update.5.0.0.