Skip to content

AGENT-1555: Add ISO No Registry presubmit job - #81816

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pawanpinjarkar:no-registry-cluster-install-job-4-origin
Jul 15, 2026
Merged

AGENT-1555: Add ISO No Registry presubmit job#81816
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pawanpinjarkar:no-registry-cluster-install-job-4-origin

Conversation

@pawanpinjarkar

@pawanpinjarkar pawanpinjarkar commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Adds a new optional ISO No Registry Agent E2E presubmit job (e2e-agent-compact-ipv4-iso-no-registry) to the OpenShift Origin CI configuration for both main and the 5.0 release pipelines. The job runs the compact IPv4 scenario on equinix-ocp-metal with ISO_NO_REGISTRY boot mode (including local cleanup of the ISO builder cache), is gated to intranet capability, and executes the agent-e2e-generic-conformance-iso-no-registry workflow. The job is inserted into the test job list immediately before the lint job in both YAML files.

During CI automation review, the OpenShift CI robot noted the target version was not configured and indicated the 5.0.0 requirement, leading to a temporary /hold that was later canceled.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: This pull request references AGENT-1555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from deads2k and p0lyn0mial July 13, 2026 14:55
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9131e531-2f51-4c45-8b70-5c4a6266f204

📥 Commits

Reviewing files that changed from the base of the PR and between 033a7f1 and 5a2ff92.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml
  • ci-operator/config/openshift/origin/openshift-origin-release-5.0.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/origin/openshift-origin-main.yaml

Walkthrough

Added an optional, intranet-gated compact IPv4 agent E2E job using ISO boot without a registry to the main and 5.0 OpenShift origin pipelines.

Changes

Agent E2E job configuration

Layer / File(s) Summary
Configure compact IPv4 ISO E2E job
ci-operator/config/openshift/origin/openshift-origin-main.yaml, ci-operator/config/openshift/origin/openshift-origin-release-5.0.yaml
Adds the optional e2e-agent-compact-ipv4-iso-no-registry job with intranet capability, the equinix-ocp-metal profile, compact IPv4 and ISO-without-registry settings, cache cleanup, and the corresponding conformance workflow.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: andfasano, deads2k, p0lyn0mial

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding an ISO No Registry presubmit job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only adds static CI job YAML entries; no Ginkgo It/Describe/Context/When test titles were added or changed.
Test Structure And Quality ✅ Passed PR only adds ci-operator YAML jobs; no Ginkgo test code, It blocks, or assertions were modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only adds CI job/config definitions, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML jobs were added; no new Ginkgo test code or SNO-sensitive test definitions changed.
Topology-Aware Scheduling Compatibility ✅ Passed CI-only job additions in ci-operator YAML; no deployment manifests, operator code, or controllers were changed.
Ote Binary Stdout Contract ✅ Passed PR only adds CI YAML job definitions; no OTE binaries or process-level stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Config-only PR; no new Ginkgo tests were added, and the referenced validation step uses only cluster-internal oc checks.
No-Weak-Crypto ✅ Passed The PR only adds CI job definitions; the added lines contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The new jobs and referenced agent/baremetalds chains contain no privileged:true, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation:true settings.
No-Sensitive-Data-In-Logs ✅ Passed Added CI job only sets scenario env and workflow; no passwords, tokens, PII, hostnames, or log-printing commands appear in the changed blocks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2026
@pawanpinjarkar
pawanpinjarkar force-pushed the no-registry-cluster-install-job-4-origin branch from 65b5674 to c11e38e Compare July 13, 2026 15:39
@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2026
Comment thread ci-operator/config/openshift/origin/openshift-origin-main.yaml
@pawanpinjarkar
pawanpinjarkar force-pushed the no-registry-cluster-install-job-4-origin branch 2 times, most recently from 44ce646 to c076f55 Compare July 14, 2026 15:32
@pawanpinjarkar
pawanpinjarkar requested a review from andfasano July 14, 2026 15:32
@pawanpinjarkar
pawanpinjarkar force-pushed the no-registry-cluster-install-job-4-origin branch from c076f55 to 033a7f1 Compare July 14, 2026 18:16
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 7ce202b89362596faf4c86914e3fd0d783f393a6 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pawanpinjarkar
pawanpinjarkar force-pushed the no-registry-cluster-install-job-4-origin branch from 033a7f1 to 5a2ff92 Compare July 14, 2026 18:20
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-agent-compact-ipv4-iso-no-registry openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-csi openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-disruptive openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-fips-serial-1of2 openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-fips-serial-2of2 openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-builds openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-image-ecosystem openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-kube-apiserver-rollout openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-pkiconfig openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-1of2 openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2 openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-main-e2e-gcp-ovn-usernamespace openshift/origin presubmit Presubmit changed
pull-ci-openshift-origin-release-5.0-e2e-agent-compact-ipv4-iso-no-registry openshift/origin presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar, pj-rehearse: failed to create rehearsal jobs ERROR:

failed waiting for prowjobs to finish: context deadline exceeded

If the problem persists, please contact Test Platform.

@andfasano

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2026
@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/assign @neisw

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-origin-main-e2e-agent-compact-ipv4-iso-no-registry

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@neisw

neisw commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar do you want this defined for 4.23 as well?

@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

@pawanpinjarkar do you want this defined for 4.23 as well?

No, our immediate need is to test only 5.0.

@neisw

neisw commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, neisw, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2026
@pawanpinjarkar

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 15, 2026
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/main/e2e-gcp-fips-serial-2of2 5a2ff92 link unknown /pj-rehearse pull-ci-openshift-origin-main-e2e-gcp-fips-serial-2of2
ci/rehearse/openshift/origin/main/e2e-agent-compact-ipv4-iso-no-registry 5a2ff92 link unknown /pj-rehearse pull-ci-openshift-origin-main-e2e-agent-compact-ipv4-iso-no-registry
ci/rehearse/openshift/origin/main/e2e-gcp-fips-serial-1of2 5a2ff92 link unknown /pj-rehearse pull-ci-openshift-origin-main-e2e-gcp-fips-serial-1of2
ci/rehearse/openshift/origin/main/e2e-gcp-disruptive 5a2ff92 link unknown /pj-rehearse pull-ci-openshift-origin-main-e2e-gcp-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit fc31b88 into openshift:main Jul 15, 2026
17 of 21 checks passed
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
amogh-redhat pushed a commit to amogh-redhat/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants