CNTRLPLANE-3788: pass --ci flag to address-review-pr skill in review-agent

[enxebre]

Summary

Pass --ci to the /openshift-developer:address-review-pr skill invocation in the review-agent harness so it runs fully non-interactively.

Why

The skill asks interactive questions in CI where there is no human to answer. The session ends without pushing, wasting the work.

Example: build 2074442484376670208 — the agent wrote correct ratcheting tests for PR #8937, committed locally, but asked "Should I push with --no-verify?" and the session ended with no push (64 turns, $3.81 wasted).

Depends on

• feat(address-review-pr): add --ci flag for non-interactive CI mode openshift-eng/ai-helpers#608 (adds --ci flag to the skill)

Ref: CNTRLPLANE-3788

Test plan

• Rehearse review-agent job and verify it pushes without asking interactive questions

🤖 Generated with Claude Code

Summary by CodeRabbit

• Enables non-interactive CI execution for the Hypershift review-agent by passing --ci to the address-review-pr skill, allowing review sessions to complete actions such as pushing changes without prompts.

[openshift-ci-robot]

@enxebre: This pull request references CNTRLPLANE-3788 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Pass --ci to the /openshift-developer:address-review-pr skill invocation in the review-agent harness so it runs fully non-interactively.

Why

The skill asks interactive questions in CI where there is no human to answer. The session ends without pushing, wasting the work.

Example: build 2074442484376670208 — the agent wrote correct ratcheting tests for PR #8937, committed locally, but asked "Should I push with --no-verify?" and the session ended with no push (64 turns, $3.81 wasted).

Depends on

• feat(address-review-pr): add --ci flag for non-interactive CI mode openshift-eng/ai-helpers#608 (adds --ci flag to the skill)

Ref: CNTRLPLANE-3788

Test plan

• Rehearse review-agent job and verify it pushes without asking interactive questions

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c2e786b4-f3f0-42f6-940f-75a8242987d8

📥 Commits

Reviewing files that changed from the base of the PR and between 651caa0 and 33f7ed6.

📒 Files selected for processing (1)

• ci-operator/step-registry/hypershift/review-agent/process/hypershift-review-agent-process-commands.sh

---

Walkthrough

The Hypershift review-agent’s Phase 1 address-review run now invokes the address-review skill with the --ci argument. Other run_claude arguments and output handling remain unchanged.

Changes

Review-agent CI invocation

Layer / File(s)	Summary
Pass CI mode to address-review ci-operator/step-registry/hypershift/review-agent/process/hypershift-review-agent-process-commands.sh	The address-review skill invocation appends --ci while preserving the remaining command arguments and output handling.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding the --ci flag to address-review-pr in the review-agent.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes a shell script invocation to add --ci; no Ginkgo test files or titles were modified.
Test Structure And Quality	✅ Passed	PR only changes a shell script to add --ci to a skill invocation; no Ginkgo test code was added or modified, so this test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	No Ginkgo tests were added; the change only adds --ci to a shell invocation, so MicroShift compatibility checks are not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo/e2e tests were added or modified; the PR only changes a shell invocation to add --ci, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a shell harness line changed to add --ci to a Claude skill invocation; no manifests, controllers, or scheduling constraints were modified.
Ote Binary Stdout Contract	✅ Passed	The PR only adds --ci to the skill prompt; it doesn’t add or alter any process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes a shell script to add --ci; no new Ginkgo tests or IPv4/external-network assumptions were introduced.
No-Weak-Crypto	✅ Passed	Diff only appends --ci to a skill invocation; no weak crypto, custom crypto, or secret comparison changes were introduced.
Container-Privileges	✅ Passed	PR only changes a shell command to add --ci; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear in the diff.
No-Sensitive-Data-In-Logs	✅ Passed	Only change adds --ci to the skill invocation; no new logging or sensitive fields were introduced, and the file’s output lines remain unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[enxebre]

another case https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-main-periodic-review-agent/2075349266066313216

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@enxebre: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-main-periodic-review-agent	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[bryan-cox]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/review-agent/process/OWNERS [bryan-cox,enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[enxebre]

/pj-rehearse ack

[openshift-merge-bot]

@enxebre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.