Add OPCT 5.0 periodic jobs with OPCT_CLI_IMAGE override - #80217
Add OPCT 5.0 periodic jobs with OPCT_CLI_IMAGE override#80217redhat-chai-bot wants to merge 1 commit into
Conversation
Add ci-operator config variant 5.0 for the OPCT periodic jobs targeting OCP 5.0 nightly releases. Override OPCT_CLI_IMAGE to use the latest OPCT version on all conformance and upgrade tests: - platform-none-vsphere - platform-none-vsphere-upgrade - platform-external-vsphere - platform-external-vsphere-upgrade
|
Hi @redhat-chai-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThis PR introduces a new CI operator configuration file for the OPCT version stream 5.0. The file defines base images (UPI installer 4.22, vSphere CI Python), release channels targeting multiple OCP versions, resource quotas for test execution, and four scheduled vSphere test jobs with reporter configuration and upgrade variants. ChangesOPCT 5.0 CI Setup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml (1)
54-54: ⚡ Quick winPin
OPCT_CLI_IMAGEto an immutable tag or digest instead oflatest.Using a mutable
:latestmakes these periodics non-reproducible and can introduce abrupt failures when the upstream image changes. Prefer a versioned tag or digest and bump intentionally.Suggested change
- OPCT_CLI_IMAGE: quay.io/opct/opct:latest + OPCT_CLI_IMAGE: quay.io/opct/opct:v0.6.5If you want strict immutability, use a digest:
- OPCT_CLI_IMAGE: quay.io/opct/opct:latest + OPCT_CLI_IMAGE: quay.io/opct/opct@sha256:<digest>Also applies to: 68-68, 84-84, 99-99
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml` at line 54, Replace the mutable OPCT_CLI_IMAGE value which currently uses the :latest tag with an immutable versioned tag or an image digest; update the OPCT_CLI_IMAGE entries (the environment variable named OPCT_CLI_IMAGE) to a fixed tag like quay.io/opct/opct:<version> or a digest quay.io/opct/opct@sha256:<digest> so periodics are reproducible and stable, and apply the same replacement for the other OPCT_CLI_IMAGE occurrences in this manifest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml`:
- Line 54: Replace the mutable OPCT_CLI_IMAGE value which currently uses the
:latest tag with an immutable versioned tag or an image digest; update the
OPCT_CLI_IMAGE entries (the environment variable named OPCT_CLI_IMAGE) to a
fixed tag like quay.io/opct/opct:<version> or a digest
quay.io/opct/opct@sha256:<digest> so periodics are reproducible and stable, and
apply the same replacement for the other OPCT_CLI_IMAGE occurrences in this
manifest.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b7fb7527-2ed8-489e-8d01-2404451e3744
⛔ Files ignored due to path filters (1)
ci-operator/jobs/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml
Summary
Add OPCT periodic job configuration for OCP 5.0, overriding
OPCT_CLI_IMAGEto use the latest OPCT version (quay.io/opct/opct:latest) at the job level for all conformance and upgrade tests.Changes
5.0forredhat-openshift-ecosystem/opctOPCT_CLI_IMAGE=quay.io/opct/opct:lateston all 4 test jobs (overrides the workflow-level default ofv0.6.5)Periodic Jobs Added
periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere— Regular conformance (None platform)periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere-upgrade— Upgrade (None platform)periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere— Regular conformance (External platform)periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere-upgrade— Upgrade (External platform)Key Config Details
rhel-9-release-golang-1.25-openshift-4.225.0candidate nightly4.22fast channel#forum-opct-updatesSummary by CodeRabbit
This PR adds CI operator configuration for OPCT (OpenShift Conformance Platform Tests) version 5.0, extending the existing testing infrastructure to cover the newer OpenShift platform version. The changes introduce:
New CI Configuration for OPCT 5.0:
redhat-openshift-ecosystem-opct-main__5.0.yaml) that defines the testing environment for OPCT 5.0Periodic Test Jobs (4 jobs total):
Key Configuration Overrides:
OPCT_CLI_IMAGEis overridden from the workflow default (v0.6.5) toquay.io/opct/opct:latestat the job level, ensuring these OPCT 5.0 tests use the latest tooling#forum-opct-updatesSlack channelThis follows the established pattern of the OPCT 4.22 configuration, providing parallel testing infrastructure for the newer major version while allowing independent configuration of test parameters and image overrides.