Skip to content

Add OPCT 5.0 periodic jobs with OPCT_CLI_IMAGE override - #80217

Closed
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:06081333-bot-changes
Closed

Add OPCT 5.0 periodic jobs with OPCT_CLI_IMAGE override#80217
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:06081333-bot-changes

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Add OPCT periodic job configuration for OCP 5.0, overriding OPCT_CLI_IMAGE to use the latest OPCT version (quay.io/opct/opct:latest) at the job level for all conformance and upgrade tests.

Changes

  • New ci-operator config variant 5.0 for redhat-openshift-ecosystem/opct
  • Overrides OPCT_CLI_IMAGE=quay.io/opct/opct:latest on all 4 test jobs (overrides the workflow-level default of v0.6.5)
  • Follows the same pattern as 4.22 with version references bumped
  • Scheduled on Thursdays (day 4), staggered hourly

Periodic Jobs Added

  • periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere — Regular conformance (None platform)
  • periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere-upgrade — Upgrade (None platform)
  • periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere — Regular conformance (External platform)
  • periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere-upgrade — Upgrade (External platform)

Key Config Details

  • Build root: rhel-9-release-golang-1.25-openshift-4.22
  • Release under test: 5.0 candidate nightly
  • Upgrade from: 4.22 fast channel
  • Failure reports: #forum-opct-updates

Summary by CodeRabbit

This PR adds CI operator configuration for OPCT (OpenShift Conformance Platform Tests) version 5.0, extending the existing testing infrastructure to cover the newer OpenShift platform version. The changes introduce:

New CI Configuration for OPCT 5.0:

  • A new CI operator config file (redhat-openshift-ecosystem-opct-main__5.0.yaml) that defines the testing environment for OPCT 5.0
  • Base images configured for vSphere testing environments with OpenShift 4.22 UPI installer and Python tooling
  • Build root using RHEL 9, Go 1.25, and OpenShift 4.22

Periodic Test Jobs (4 jobs total):

  • Regular conformance tests on vSphere (both None and External platforms)
  • Upgrade tests on vSphere (both None and External platforms)
  • All jobs scheduled weekly on Thursdays with staggered hourly execution
  • Upgrade tests configured to test the 4.22 → 5.0 upgrade path

Key Configuration Overrides:

  • The OPCT_CLI_IMAGE is overridden from the workflow default (v0.6.5) to quay.io/opct/opct:latest at the job level, ensuring these OPCT 5.0 tests use the latest tooling
  • Tests target 5.0 candidate nightly releases for the new platform version
  • Failure reports directed to the #forum-opct-updates Slack channel

This follows the established pattern of the OPCT 4.22 configuration, providing parallel testing infrastructure for the newer major version while allowing independent configuration of test parameters and image overrides.

Add ci-operator config variant 5.0 for the OPCT periodic jobs targeting
OCP 5.0 nightly releases. Override OPCT_CLI_IMAGE to use the latest
OPCT version on all conformance and upgrade tests:

- platform-none-vsphere
- platform-none-vsphere-upgrade
- platform-external-vsphere
- platform-external-vsphere-upgrade
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi @redhat-chai-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR introduces a new CI operator configuration file for the OPCT version stream 5.0. The file defines base images (UPI installer 4.22, vSphere CI Python), release channels targeting multiple OCP versions, resource quotas for test execution, and four scheduled vSphere test jobs with reporter configuration and upgrade variants.

Changes

OPCT 5.0 CI Setup

Layer / File(s) Summary
Build and base image configuration
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml
Base images pin UPI installer to 4.22 and vSphere CI Python to ci/latest; build root image stream targets RHEL 9 with Go 1.25 and OpenShift 4.22.
Release channels and resource allocation
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml
Release channels defined for initial namespace, 4.22 fast track, and 5.0 nightly candidate; global resource limits (4Gi memory, 100m CPU) with higher allocation for UPI installer pool.
Scheduled test jobs
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml
Four cron-scheduled test jobs for vSphere platform and external cluster variants (non-upgrade and upgrade); each includes reporter config, vSphere cluster profile, and environment variables; upgrade jobs set run mode to upgrade and target candidate channel.
Configuration metadata
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml
Generated metadata records source branch, GitHub repository, and configuration variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • openshift/release#77698: Adjusts periodic job configurations to target the OpenShift/OPCT 5.0 release stream, complementing the addition of this new 5.0 CI operator configuration.

Suggested labels

lgtm, approved, rehearsals-ack, ok-to-test

Suggested reviewers

  • mtulio
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding OPCT 5.0 periodic jobs with a specific configuration override (OPCT_CLI_IMAGE), which matches the core content of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only YAML CI config with no Ginkgo test code or test titles to evaluate. Check is not applicable to configuration-only changes.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test structure is not applicable; the PR adds standard Go unit tests (using testing.T), not Ginkgo BDD tests (no Describe/Context/It blocks present).
Microshift Test Compatibility ✅ Passed PR only adds CI configuration YAML; no Ginkgo e2e tests are introduced, so MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR; only CI configuration YAML is modified. The check for SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds only a CI Operator config file (not a deployment manifest, operator code, or controller) with no scheduling constraints or topology-aware issues.
Ote Binary Stdout Contract ✅ Passed PR only adds YAML configs and shell test harnesses, not OTE binary code. Check applies to Go process-level code violations; no such code present here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only CI operator configuration YAML for OPCT 5.0 periodic jobs; no new Ginkgo e2e tests are introduced, so the IPv6/disconnected network compatibility check does not apply.
No-Weak-Crypto ✅ Passed PR contains only YAML configuration files with no weak crypto algorithms (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), custom crypto implementations, or insecure secret comparisons detected.
Container-Privileges ✅ Passed The new OPCT 5.0 CI config file contains no privileged container settings, hostPID/Network/IPC, SYS_ADMIN capabilities, root escalation, or allowPrivilegeEscalation flags.
No-Sensitive-Data-In-Logs ✅ Passed YAML CI config contains no sensitive data: no passwords, tokens, API keys, credentials, PII, or session IDs. All environment variables are non-sensitive configuration parameters.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from bshaw7 and rvanderp3 June 8, 2026 13:44
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere N/A periodic Periodic changed
periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere N/A periodic Periodic changed
periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-external-vsphere-upgrade N/A periodic Periodic changed
periodic-ci-redhat-openshift-ecosystem-opct-main-5.0-platform-none-vsphere-upgrade N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml (1)

54-54: ⚡ Quick win

Pin OPCT_CLI_IMAGE to an immutable tag or digest instead of latest.

Using a mutable :latest makes these periodics non-reproducible and can introduce abrupt failures when the upstream image changes. Prefer a versioned tag or digest and bump intentionally.

Suggested change
-      OPCT_CLI_IMAGE: quay.io/opct/opct:latest
+      OPCT_CLI_IMAGE: quay.io/opct/opct:v0.6.5

If you want strict immutability, use a digest:

-      OPCT_CLI_IMAGE: quay.io/opct/opct:latest
+      OPCT_CLI_IMAGE: quay.io/opct/opct@sha256:<digest>

Also applies to: 68-68, 84-84, 99-99

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml`
at line 54, Replace the mutable OPCT_CLI_IMAGE value which currently uses the
:latest tag with an immutable versioned tag or an image digest; update the
OPCT_CLI_IMAGE entries (the environment variable named OPCT_CLI_IMAGE) to a
fixed tag like quay.io/opct/opct:<version> or a digest
quay.io/opct/opct@sha256:<digest> so periodics are reproducible and stable, and
apply the same replacement for the other OPCT_CLI_IMAGE occurrences in this
manifest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml`:
- Line 54: Replace the mutable OPCT_CLI_IMAGE value which currently uses the
:latest tag with an immutable versioned tag or an image digest; update the
OPCT_CLI_IMAGE entries (the environment variable named OPCT_CLI_IMAGE) to a
fixed tag like quay.io/opct/opct:<version> or a digest
quay.io/opct/opct@sha256:<digest> so periodics are reproducible and stable, and
apply the same replacement for the other OPCT_CLI_IMAGE occurrences in this
manifest.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b7fb7527-2ed8-489e-8d01-2404451e3744

📥 Commits

Reviewing files that changed from the base of the PR and between 91df2be and 076a7ab.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/redhat-openshift-ecosystem/opct/redhat-openshift-ecosystem-opct-main__5.0.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant