Skip to content

Revert "Block build13 from CI rotation due to CDN connectivity issues" - #80002

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
deepsm007:revert-79962-block-build13
Jun 3, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
deepsm007:revert-79962-block-build13

Conversation

@deepsm007

@deepsm007 deepsm007 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Reverts #79962

Summary by CodeRabbit

This PR reverts a previous change that had blocked the build13 GCP build cluster from accepting new CI jobs due to CDN connectivity issues. The revert restores build13 to active status in the CI infrastructure by changing its blocked flag from true back to false in the cluster configuration.

The cluster configuration file (core-services/sanitize-prow-jobs/_clusters.yaml) defines the available build clusters used by OpenShift's CI infrastructure, including their status and capabilities. This change re-enables build13 — a GCP-hosted cluster with KVM support and a capacity of 100 agents — for scheduling of Prow jobs across the CI system. The underlying assumption is that the CDN connectivity issues that prompted the initial blocking have been resolved.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deepsm007: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR unblocks the build13 GCP cluster in the Prow job sanitization configuration by changing its blocked flag from true to false, enabling it for job scheduling and usage.

Changes

Cluster Configuration Update

Layer / File(s) Summary
Enable build13 GCP cluster
core-services/sanitize-prow-jobs/_clusters.yaml
The blocked flag for the build13 cluster entry in the gcp cluster list is set to false, unblocking it for job scheduling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#79962: Both PRs modify core-services/sanitize-prow-jobs/_clusters.yaml for the gcp cluster build13, flipping its blocked flag in opposite directions.

Suggested labels

lgtm, approved, rehearsals-ack

Suggested reviewers

  • Prucek
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a previous block on the build13 cluster, which aligns with the YAML modification that changes the blocked flag from true to false.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies a YAML configuration file (_clusters.yaml) and documentation; it contains no Ginkgo tests, making the test name stability check inapplicable.
Test Structure And Quality ✅ Passed PR contains only a YAML configuration change to _clusters.yaml, with no Ginkgo test code to review. Custom check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed This PR only modifies YAML configuration to revert a cluster block (build13 blocked: true → false) and does not add any new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR makes only YAML configuration changes (enabling build13 cluster). No new Ginkgo e2e tests are added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes only a Prow CI cluster configuration file, setting build13's blocked flag to false. No deployment manifests, operator code, controllers, or scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only modifies _clusters.yaml (YAML configuration), not source code. OTE Binary Stdout Contract check applies to binary/source code only, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies YAML cluster configuration (_clusters.yaml). No Ginkgo e2e tests added; check requires new test code to evaluate.
No-Weak-Crypto ✅ Passed PR changes only YAML configuration file (_clusters.yaml) to enable build13 cluster; no cryptographic code, weak crypto algorithms, or token comparisons present.
Container-Privileges ✅ Passed File contains only cluster configuration, no K8s manifests or privilege-escalation fields like privileged, hostPID, hostNetwork, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed PR modifies only a YAML configuration file to change a cluster's blocked status. No logging code is added, and the config contains no sensitive data.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from droslean and hector-vido June 3, 2026 00:21
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
core-services/sanitize-prow-jobs/_clusters.yaml (1)

95-100: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Unblock build13 only with proof the “CDN connectivity issues” are resolved

The change sets build13 to blocked: false, but the codebase search doesn’t contain any build13-specific evidence tying the previous “CDN connectivity issues” to a completed fix. The earlier GitHub incidents lookup can’t provide further signal because openshift/release issues are disabled (only the revert PR was visible).

Provide a link to the incident/ticket or postmortem showing the CDN fix is complete for build13, plus infra confirmation that build13 is healthy (successful connectivity/blackbox probes) before re-enabling for CI rotation.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@core-services/sanitize-prow-jobs/_clusters.yaml` around lines 95 - 100, The
change flips the cluster entry "name: build13" to "blocked: false" without
providing evidence the prior "CDN connectivity issues" are resolved; revert or
keep "blocked: true" for name: build13 until you attach a ticket/postmortem link
and infra health confirmation. Update the PR and the cluster entry (the block
around name: build13 / blocked: false) to include a comment or metadata pointing
to the incident/ticket/postmortem URL and a short infra verification note
(successful connectivity/blackbox probe timestamps or a link to the probe
dashboard), or leave blocked: true and reference those artifacts in the PR
description before enabling it for CI rotation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@core-services/sanitize-prow-jobs/_clusters.yaml`:
- Around line 95-100: The change flips the cluster entry "name: build13" to
"blocked: false" without providing evidence the prior "CDN connectivity issues"
are resolved; revert or keep "blocked: true" for name: build13 until you attach
a ticket/postmortem link and infra health confirmation. Update the PR and the
cluster entry (the block around name: build13 / blocked: false) to include a
comment or metadata pointing to the incident/ticket/postmortem URL and a short
infra verification note (successful connectivity/blackbox probe timestamps or a
link to the probe dashboard), or leave blocked: true and reference those
artifacts in the PR description before enabling it for CI rotation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 97cacd97-8d00-4397-a1ed-49cde8893b8b

📥 Commits

Reviewing files that changed from the base of the PR and between 481440a and 99cc7bd.

📒 Files selected for processing (1)
  • core-services/sanitize-prow-jobs/_clusters.yaml

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@deepsm007: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hector-vido

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 098b9c1 into openshift:main Jun 3, 2026
7 checks passed
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jun 4, 2026
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
srivickynesh pushed a commit to srivickynesh/release that referenced this pull request Aug 5, 2026
malingatembo pushed a commit to malingatembo/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants