Revert "Block build13 from CI rotation due to CDN connectivity issues" - #80002
openshift-merge-bot[bot] merged 1 commit into
Conversation
…openshift#79962)" This reverts commit 729b498.
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
WalkthroughThis PR unblocks the ChangesCluster Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
core-services/sanitize-prow-jobs/_clusters.yaml (1)
95-100:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUnblock
build13only with proof the “CDN connectivity issues” are resolvedThe change sets
build13toblocked: false, but the codebase search doesn’t contain any build13-specific evidence tying the previous “CDN connectivity issues” to a completed fix. The earlier GitHub incidents lookup can’t provide further signal becauseopenshift/releaseissues are disabled (only the revert PR was visible).Provide a link to the incident/ticket or postmortem showing the CDN fix is complete for build13, plus infra confirmation that
build13is healthy (successful connectivity/blackbox probes) before re-enabling for CI rotation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core-services/sanitize-prow-jobs/_clusters.yaml` around lines 95 - 100, The change flips the cluster entry "name: build13" to "blocked: false" without providing evidence the prior "CDN connectivity issues" are resolved; revert or keep "blocked: true" for name: build13 until you attach a ticket/postmortem link and infra health confirmation. Update the PR and the cluster entry (the block around name: build13 / blocked: false) to include a comment or metadata pointing to the incident/ticket/postmortem URL and a short infra verification note (successful connectivity/blackbox probe timestamps or a link to the probe dashboard), or leave blocked: true and reference those artifacts in the PR description before enabling it for CI rotation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@core-services/sanitize-prow-jobs/_clusters.yaml`:
- Around line 95-100: The change flips the cluster entry "name: build13" to
"blocked: false" without providing evidence the prior "CDN connectivity issues"
are resolved; revert or keep "blocked: true" for name: build13 until you attach
a ticket/postmortem link and infra health confirmation. Update the PR and the
cluster entry (the block around name: build13 / blocked: false) to include a
comment or metadata pointing to the incident/ticket/postmortem URL and a short
infra verification note (successful connectivity/blackbox probe timestamps or a
link to the probe dashboard), or leave blocked: true and reference those
artifacts in the PR description before enabling it for CI rotation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 97cacd97-8d00-4397-a1ed-49cde8893b8b
📒 Files selected for processing (1)
core-services/sanitize-prow-jobs/_clusters.yaml
|
@deepsm007: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reverts #79962
Summary by CodeRabbit
This PR reverts a previous change that had blocked the
build13GCP build cluster from accepting new CI jobs due to CDN connectivity issues. The revert restoresbuild13to active status in the CI infrastructure by changing itsblockedflag fromtrueback tofalsein the cluster configuration.The cluster configuration file (
core-services/sanitize-prow-jobs/_clusters.yaml) defines the available build clusters used by OpenShift's CI infrastructure, including their status and capabilities. This change re-enablesbuild13— a GCP-hosted cluster with KVM support and a capacity of 100 agents — for scheduling of Prow jobs across the CI system. The underlying assumption is that the CDN connectivity issues that prompted the initial blocking have been resolved.