Skip to content

Allow openshift-staff-engineers to apply priority/ci-critical label - #79964

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stbenjam:allow-me
Jun 2, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
stbenjam:allow-me

Conversation

@stbenjam

@stbenjam stbenjam commented Jun 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds openshift-staff-engineers to the allowed_teams for the priority/ci-critical restricted label on openshift/release
  • Staff engineers need this label to flag CI-critical issues (e.g., #79962)

Test plan

  • Verify prow config validation passes (make checkconfig)

🤖 Generated with Claude Code

Summary by CodeRabbit

This PR updates the Prow configuration for the openshift/release repository to grant additional permissions for applying the priority/ci-critical label. Specifically, the openshift-staff-engineers team is now added to the list of teams authorized to apply this restricted label, joining the existing test-platform team.

Impact: Staff engineers can now directly flag CI-critical issues in the OpenShift release repository without requiring a separate review or approval from the test platform team, improving the efficiency of addressing critical CI infrastructure issues.

Files modified:

  • core-services/prow/02_config/openshift/release/_pluginconfig.yaml (+1 line)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: bc39901b-8837-403e-beba-724da0bd9ed3

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe2466 and f419741.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift/release/_pluginconfig.yaml

Walkthrough

This pull request updates the Prow label policy configuration for the openshift/release repository by adding the openshift-staff-engineers team to the list of authorized teams that can manage restricted labels.

Changes

Label Policy Authorization

Layer / File(s) Summary
Staff Engineers Label Authorization
core-services/prow/02_config/openshift/release/_pluginconfig.yaml
Added openshift-staff-engineers as an allowed team under label.restricted_labels to grant label management permissions to this team in the openshift/release repository.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding openshift-staff-engineers to allowed teams for the priority/ci-critical label.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only a Prow configuration YAML file and contains no Ginkgo test code, so the requirement for stable test names is not applicable.
Test Structure And Quality ✅ Passed This PR modifies only Prow configuration files (YAML), not test code. No Ginkgo tests are present in the changes, making the test structure quality check not applicable.
Microshift Test Compatibility ✅ Passed PR only modifies Prow configuration file (_pluginconfig.yaml), not adding any Ginkgo e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies Prow label policy configuration files only. No new Ginkgo e2e tests are added, so the SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a Prow plugin configuration file to grant label permissions, not deployment manifests, operator code, or controllers; therefore, the topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies Prow configuration YAML, not OTE binaries or code affecting stdout behavior. OTE Binary Stdout Contract check is not applicable to YAML configuration changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests, only Prow configuration updates. Custom check for IPv6/disconnected network compatibility is not applicable.
No-Weak-Crypto ✅ Passed PR contains only YAML configuration changes to add a team to a Prow label policy; no cryptographic code, weak crypto patterns, custom crypto implementations, or secret comparisons are present.
Container-Privileges ✅ Passed PR modifies Prow label policy config, not a container/K8s manifest. No privileged settings, hostPID, hostNetwork, hostIPC, or allowPrivilegeEscalation found.
No-Sensitive-Data-In-Logs ✅ Passed PR is a configuration change adding a team name to access control policy; contains no logging code or sensitive data exposure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
openshift-ci Bot requested review from bear-redhat and pruan-rht June 2, 2026 10:03
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 2, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@stbenjam: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@deepsm007

Copy link
Copy Markdown
Contributor

/label priority/ci-critical

@openshift-ci openshift-ci Bot added the priority/ci-critical Critical priority - CI infrastructure is broken or severely impacted label Jun 2, 2026
@deepsm007

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026
@openshift-ci

openshift-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit bdee583 into openshift:main Jun 2, 2026
12 checks passed
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jun 2, 2026
krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
SachinNinganure pushed a commit to SachinNinganure/release that referenced this pull request Jul 20, 2026
srivickynesh pushed a commit to srivickynesh/release that referenced this pull request Aug 5, 2026
malingatembo pushed a commit to malingatembo/release that referenced this pull request Aug 5, 2026
TimurMP pushed a commit to TimurMP/release that referenced this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/ci-critical Critical priority - CI infrastructure is broken or severely impacted rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants