Skip to content

Conversation

@patrickdillon
Copy link
Contributor

Cluster is only required for IPI--not UPI. It would be better to
exclude cluster from the UPI template to ensure that IPI validation
doesn't break UPI.

This reverts commit 3b27772.

Cluster is only required for IPI--not UPI. It would be better to
exclude cluster from the UPI template to ensure that IPI validation
doesn't break UPI.

This reverts commit 3b27772.
@patrickdillon
Copy link
Contributor Author

/test pj-rehearse

2 similar comments
@jcpowermac
Copy link
Contributor

/test pj-rehearse

@jcpowermac
Copy link
Contributor

/test pj-rehearse

@jcpowermac
Copy link
Contributor

Based on the failure I know that it got passed the openshift-install command.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, patrickdillon
To complete the pull request process, please assign iamemilio
You can assign the PR to them by writing /assign @iamemilio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

@abhinavdahiya or @sdodson can one of you approve this please?

@abhinavdahiya
Copy link
Contributor

/test pj-rehearse

@jcpowermac
Copy link
Contributor

@abhinavdahiya @patrickdillon needs to be rebased if you want vsphere to pass

@patrickdillon
Copy link
Contributor Author

/retest
not sure I understand what's going on here
rebase? I see no merge conflict in github and local rebase shows no changes...

@patrickdillon
Copy link
Contributor Author

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere-operator 7c8fc61 link /test pj-rehearse
ci/prow/pj-rehearse 7c8fc61 link /test pj-rehearse
ci/prow/release-controller-config 7c8fc61 link /test release-controller-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

/close

@openshift-ci-robot
Copy link
Contributor

@patrickdillon: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants