-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Revert "VSphere UPI: Add cluster to install-config." #7989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "VSphere UPI: Add cluster to install-config." #7989
Conversation
Cluster is only required for IPI--not UPI. It would be better to exclude cluster from the UPI template to ensure that IPI validation doesn't break UPI. This reverts commit 3b27772.
|
/test pj-rehearse |
2 similar comments
|
/test pj-rehearse |
|
/test pj-rehearse |
|
Based on the failure I know that it got passed the openshift-install command. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jcpowermac, patrickdillon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@abhinavdahiya or @sdodson can one of you approve this please? |
|
/test pj-rehearse |
|
@abhinavdahiya @patrickdillon needs to be rebased if you want vsphere to pass |
|
/retest |
|
/test pj-rehearse |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@patrickdillon: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cluster is only required for IPI--not UPI. It would be better to
exclude cluster from the UPI template to ensure that IPI validation
doesn't break UPI.
This reverts commit 3b27772.