CNTRLPLANE-3375: Add ExternalOIDCWithUpstreamParity Default jobs - #79310
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@ShazaAldawamneh: This pull request references CNTRLPLANE-3375 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated platform-specific upstream-parity periodic tests to use TechPreview configurations. Added default 24-hour upstream-parity tests for AWS, Azure, GCP, vSphere, Metal OVN, and AWS SNO. ChangesUpstream-parity periodic test configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml`:
- Line 457: The cron schedule for the vSphere periodic is set to weekly ("cron:
30 21 * * 3") but should run daily; update the YAML entry for the cron key (the
line containing "cron") to a daily schedule such as "30 21 * * *" so the job
runs every day at 21:30 UTC.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3e437c22-7c02-42c3-aca1-91c0d7849466
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.23__periodics.yamlci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml
There was a problem hiding this comment.
As @everettraven pointed out in a conversation, we should probably have only 5.0 periodics.
Since openshift/hypershift#8287 adds new tests for this feature gate, we should probably hold off on merging until this one is merged.
openshift-ci
Bot
added
the
needs-rebase
8ebf3f5 to
a600ed7
Compare
openshift-ci
Bot
removed
the
needs-rebase
a600ed7 to
de37fde
Compare
ShazaAldawamneh
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/hold Holding as this PR is dependent on tests in openshift/hypershift#8287 . Once this is merged we can lift the hold. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
Since openshift/hypershift#8287 is merged, feel free to address the merge conflict and suggestions above + unhold. :) |
openshift-ci
Bot
added
the
needs-rebase
de37fde to
da7f4ac
Compare
openshift-ci
Bot
removed
needs-rebase
|
/remove-hold |
openshift-ci
Bot
removed
the
do-not-merge/hold
| TEST_SUITE: openshift/auth/external-oidc | ||
| workflow: openshift-e2e-aws-single-node | ||
| - as: e2e-aws-external-oidc-upstream-parity | ||
| - as: e2e-aws-external-oidc-upstream-parity-tp |
There was a problem hiding this comment.
The general pattern for techpreview jobs is to fully spell out "techpreview" at the end.
| - as: e2e-aws-external-oidc-upstream-parity-tp | |
| - as: e2e-aws-external-oidc-upstream-parity-techpreview |
openshift-ci
Bot
added
the
needs-rebase
e3289d8 to
ef90d1b
Compare
|
@ShazaAldawamneh, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
It looks like we need to re-generate job configurations alongside this change. Other than that, this LGTM.
openshift-ci
Bot
added
the
needs-rebase
|
@ShazaAldawamneh, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
0157fbe to
bde4dd7
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
A total of 36 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehearne-redhat, everettraven, ShazaAldawamneh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Looks like there aren't any accepted CI payloads with the gate enabled by default yet so these rehearsals will probably fail until then. |
|
@ShazaAldawamneh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-gcp-external-oidc-upstream-parity |
|
@everettraven: your |
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-5.0-periodics-e2e-gcp-external-oidc-upstream-parity |
|
@ShazaAldawamneh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
072ffbc
into
openshift:main
…nshift#79310) * Promote ExternalOIDCWithUpstreamParity to Default feature set Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com> * Shorten dualstack test name to fit 61-char limit and regenerate jobs Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com> --------- Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
4 participants
This PR adds periodic Prow jobs for the
ExternalOIDCWithUpstreamParityfeature gate running on the Default feature set, enabling automated regression testing once the feature is promoted from TechPreview to GA.This PR should be merged alongside the feature gate promotion PR in openshift/api.
Changes
Periodic Jobs Added
Creates daily periodic test jobs for the Default feature set across all supported platforms and releases:
Platforms (all 8 required for promotion):
Releases:
Summary by CodeRabbit
ExternalOIDCWithUpstreamParityperiodic jobs for the Default feature set.*-techpreviewand assignedFEATURE_SET: TechPreviewNoUpgrade.