Capture more debugging output in steps #7899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickdillon
force-pushed
the
steps-increase-debugging
branch
from
51a03d9 to
cca7241
Compare
Contributor
Author
|
/test pj-rehearse |
ci-operator/step-registry/ipi/deprovision/deprovision/ipi-deprovision-deprovision-commands.sh
Outdated
Show resolved
Hide resolved
In the event of an installation failure, log bundles were not being added to artifacts dir. This commit attempts to identify a log bundle by pattern matching and discards any errors if the file doesn't exist.
…tep. This commit adds .openshift_install.log to $SHARED_DIR in install so it can be appended to in deprovision, enables trace level debugging and writes .openshift_install.log,from deprovision to the artifacts. This will be useful for debugging any deprovisioning failures.
Terraform is not used to destroy the vSphere cluster so this environment variable is not helping. Remove for clarity.
patrickdillon
force-pushed
the
steps-increase-debugging
branch
from
cca7241 to
06c8d90
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@patrickdillon: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 30, 2020
Steve found this opaque [1], so shift the cp into the 'set +e' block instead. The '|| :' syntax was originally from 20157f6 (Capture log bundle in install step, 2020-03-24, openshift#7899). [1]: https://github.com/openshift/release/pull/7936/files#r400512879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @wking @abhinavdahiya