OCM-23829 Migrate cs-rosa-hcp-autonode-integration-main OCM FVT job to Prow periodic - #78772
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
WalkthroughAdds a new ci-operator YAML that defines an OpenShift Rosa e2e pipeline entry (ocm-fvt-rosa-hcp-integration) with base images, build_root, OCP nightly release selection, resource limits, a podman-based test invocation, volume mounts for credentials, and generated metadata. ChangesRosa E2E Test Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
4b566a4 to
9487bad
Compare
tinaafitz
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml (2)
46-52: ⚡ Quick win
ocmci:latestmutable tag risks silent test-logic drift.
quay.io/redhat-services-prod/ocmci/ocmci:latestchanges on every push without a corresponding config diff, making failures hard to bisect. Pin to a digest or a versioned tag so the test definition is stable and reproducible.- quay.io/redhat-services-prod/ocmci/ocmci:latest \ + quay.io/redhat-services-prod/ocmci/ocmci@sha256:<digest> \ # or a versioned tag🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml` around lines 46 - 52, The podman invocation uses the mutable image tag quay.io/redhat-services-prod/ocmci/ocmci:latest which can change silently; update the podman run command to pin the image to an immutable identifier (either a digest or a specific versioned tag) instead of :latest so the job is reproducible—replace quay.io/redhat-services-prod/ocmci/ocmci:latest in the podman run line with a digest (e.g., `@sha256`:...) or a fixed version tag for the ocmci image.
1-5: ⚡ Quick win
nested-podman:latestis the established pattern for this codebase — consider pinning only if addressing repo-wide.Using
:latestfor thenested-podmanbase image is a mutable tag. However, this pattern is consistent across all similar OCM FVT ROSA configurations in the repository (integration, staging, and periodic tests). If pinning to a stable tag is desired, it should be addressed as a repo-wide decision affecting all similar configurations, rather than isolated to this file.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml` around lines 1 - 5, The base image entry uses a mutable tag "latest" for base_images.nested-podman (name: nested-podman, tag: latest); to fix, either change tag to a specific immutable digest or version (e.g., replace tag: latest with a pinned tag or digest) or leave as-is but instead open a repo-wide change to update all OCM FVT ROSA configs consistently; update the nested-podman block accordingly (base_images → nested-podman → tag) to reflect the chosen approach.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Around line 33-40: The heredoc builds JOB_LINK using PULL_NUMBER, JOB_NAME and
BUILD_ID but runs under a cleaned environment (env -i bash), so JOB_NAME and
BUILD_ID may be unset; either export those Prow vars into the heredoc
environment before invoking the heredoc or guard their usage with defaults
inside the heredoc (e.g., use ${JOB_NAME:-unknown} and ${BUILD_ID:-unknown}) so
JOB_LINK is never constructed with empty values; update the code that sets
JOB_LINK/echo/export JOB_LINK accordingly to reference these guarded variables
or to export PULL_NUMBER, JOB_NAME, BUILD_ID into the heredoc caller.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Around line 46-52: The podman invocation uses the mutable image tag
quay.io/redhat-services-prod/ocmci/ocmci:latest which can change silently;
update the podman run command to pin the image to an immutable identifier
(either a digest or a specific versioned tag) instead of :latest so the job is
reproducible—replace quay.io/redhat-services-prod/ocmci/ocmci:latest in the
podman run line with a digest (e.g., `@sha256`:...) or a fixed version tag for the
ocmci image.
- Around line 1-5: The base image entry uses a mutable tag "latest" for
base_images.nested-podman (name: nested-podman, tag: latest); to fix, either
change tag to a specific immutable digest or version (e.g., replace tag: latest
with a pinned tag or digest) or leave as-is but instead open a repo-wide change
to update all OCM FVT ROSA configs consistently; update the nested-podman block
accordingly (base_images → nested-podman → tag) to reflect the chosen approach.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 103920bb-7125-40f7-88f7-fc91c8f6a1ce
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
|
@tinaafitz: job(s): periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main either don't exist or were not found to be affected, and cannot be rehearsed |
9487bad to
b40b703
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tinaafitz: job(s): periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest-required |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b40b703 to
e94185b
Compare
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tinaafitz, |
…integration variant
e94185b to
ee803f5
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-autonode-integration-main |
|
@tinaafitz: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@tinaafitz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, gacalixto, tinaafitz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
9a2d67f
into
openshift:main
…integration variant (openshift#78772)
…integration variant (openshift#78772)
…integration variant (openshift#78772)
…integration variant (openshift#78772)
…integration variant (openshift#78772)
…integration variant (openshift#78772)
…integration variant (openshift#78772)
3 participants
Summary
cs-rosa-hcp-autonode-integration-mainOCM FVT jobDetails
0 8 * * *(08:00 UTC daily)cms-hcp-autonode-gating-testOpenShift Rosa e2e CI — Add ROSA HCP AutoNode OCM FVT Periodic Job
Adds a new Prow periodic job configuration to the openshift/release CI configs for the OpenShift Rosa e2e integration suite. This PR creates a new ci-operator variant (ocm-fvt-rosa-hcp-integration) and a periodic Prow job to run OCM Functional Validation Tests (FVT) for the ROSA HCP AutoNode feature against the integration OCM environment.
What changed
Impact / rationale
References