MGMT-23721: add VMaaS periodic E2E jobs to Prow - #77782
openshift-merge-bot[bot] merged 4 commits into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@omer-vishlitzky: This pull request references MGMT-23721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdded an images build for Changes
Sequence Diagram(s)sequenceDiagram
participant Prow as Prow Job
participant CI as ci-operator Container
participant Remote as ci_machine (SSH)
participant Podman as Podman/OSAC Test Container
participant Cluster as Kubernetes (kubeconfig)
Prow->>CI: start periodic/presubmit job
CI->>Remote: ssh (pass TEST,E2E_*,OSAC_TEST_IMAGE)
Remote->>Remote: validate /root/kubeconfig and pull-secret
Remote->>Podman: podman run OSAC_TEST_IMAGE (mount kubeconfig, pull-secret, env)
Podman->>Cluster: run tests (make test TEST=...)
Podman-->>Remote: exit status/logs
Remote-->>CI: exit status/logs
CI-->>Prow: job result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@omer-vishlitzky, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@omer-vishlitzky: This pull request references MGMT-23721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml (1)
14-16: Documentation example is slightly inconsistent with actual test names.The documentation shows
test_compute_instance_lifecyclebut the jobs in the config file use names liketest_compute_instance_creation,test_compute_instance_restart, etc. Consider updating the example to match an actual test name for clarity.- name: TEST - documentation: The test name to run (e.g. test_compute_instance_lifecycle) + documentation: The test name to run (e.g. test_compute_instance_creation)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml` around lines 14 - 16, The env documentation for the TEST variable shows an inconsistent example ("test_compute_instance_lifecycle"); update the example string used in the documentation for the env key TEST to match an actual job name present in this config (e.g., "test_compute_instance_creation" or another real test like "test_compute_instance_restart") so the documentation aligns with the configured job names.ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml (1)
61-204: Consider using YAML anchors to reduce configuration duplication.All 8 E2E jobs share identical
ASSISTED_CONFIGblocks (lines 68-76, 86-94, etc.). This repetition increases maintenance burden and risk of inconsistent updates.YAML anchors can define the shared configuration once:
Example refactor using YAML anchors
# Define anchor at the first job - as: e2e-metal-vmaas-compute-instance-creation capabilities: - intranet cron: 0 2 * * 1 steps: cluster_profile: packet-assisted env: ASSISTED_CONFIG: &vmaas-assisted-config | OLM_OPERATORS=cnv NUM_MASTERS=1 NUM_WORKERS=0 MASTER_MEMORY=57344 MASTER_DISK_COUNT=2 MASTER_DISK=200000000000 MASTER_CPU=24 OPENSHIFT_VERSION=4.20 TEST: test_compute_instance_creation workflow: osac-project-ofcir-baremetal # Subsequent jobs reference the anchor - as: e2e-metal-vmaas-compute-instance-api-fields capabilities: - intranet cron: 0 6 * * 1 steps: cluster_profile: packet-assisted env: ASSISTED_CONFIG: *vmaas-assisted-config TEST: test_compute_instance_api_fields workflow: osac-project-ofcir-baremetal🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml` around lines 61 - 204, The repeated ASSISTED_CONFIG block should be factored into a single YAML anchor and referenced by the other jobs: create an anchor (e.g. &vmaas-assisted-config) on the ASSISTED_CONFIG scalar in the first job (as: e2e-metal-vmaas-compute-instance-creation) and replace the inline ASSISTED_CONFIG blocks in the other jobs (e.g. e2e-metal-vmaas-compute-instance-api-fields, -cli-fields, -delete-during-provision, -restart, -restart-negative, -subnet-lifecycle, -virtual-network-lifecycle) with the alias (*vmaas-assisted-config) so each job still sets TEST uniquely but reuses the shared ASSISTED_CONFIG.ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh (1)
23-23:set +xis unnecessary - tracing was never enabled.The script has
set -o nounset,set -o errexit,set -o pipefailbut never enables tracing withset -x. Theset +xon line 23 has no effect.If the intent is defensive (to prevent secrets from being logged if someone adds
-xlater), consider adding a comment explaining this, or simply remove the line.-set +x +# Disable trace to prevent secrets from appearing in logs +set +x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh` at line 23, Remove the no-op defensive trace-disable: delete the standalone "set +x" line (it has no effect since tracing isn't enabled) from the script; if you want to keep a defensive note instead, replace it with a brief comment explaining it's intentionally omitted to prevent accidental tracing of secrets rather than the actual "set +x" command.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml`:
- Around line 61-204: The repeated ASSISTED_CONFIG block should be factored into
a single YAML anchor and referenced by the other jobs: create an anchor (e.g.
&vmaas-assisted-config) on the ASSISTED_CONFIG scalar in the first job (as:
e2e-metal-vmaas-compute-instance-creation) and replace the inline
ASSISTED_CONFIG blocks in the other jobs (e.g.
e2e-metal-vmaas-compute-instance-api-fields, -cli-fields,
-delete-during-provision, -restart, -restart-negative, -subnet-lifecycle,
-virtual-network-lifecycle) with the alias (*vmaas-assisted-config) so each job
still sets TEST uniquely but reuses the shared ASSISTED_CONFIG.
In
`@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh`:
- Line 23: Remove the no-op defensive trace-disable: delete the standalone "set
+x" line (it has no effect since tracing isn't enabled) from the script; if you
want to keep a defensive note instead, replace it with a brief comment
explaining it's intentionally omitted to prevent accidental tracing of secrets
rather than the actual "set +x" command.
In
`@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml`:
- Around line 14-16: The env documentation for the TEST variable shows an
inconsistent example ("test_compute_instance_lifecycle"); update the example
string used in the documentation for the env key TEST to match an actual job
name present in this config (e.g., "test_compute_instance_creation" or another
real test like "test_compute_instance_restart") so the documentation aligns with
the configured job names.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c362ff9c-9fad-41a1-8a8b-740d7a5d0e9e
📒 Files selected for processing (6)
ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yamlci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.shci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yamlci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
56c3577 to
afd6d21
Compare
|
@omer-vishlitzky: This pull request references MGMT-23721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh (1)
9-35: Well-structured remote E2E execution.The SSH-based remote test execution with heredoc, positional argument passing, and kubeconfig discovery is cleanly implemented. The 60-minute timeout is reasonable for E2E tests.
Minor cleanup: Line 23
set +xappears unnecessary since there's no correspondingset -xearlier in the remote script. Consider removing it.,
🧹 Optional: Remove unused trace toggle
PULL_SECRET_PATH="/root/pull-secret" -set +x podman run --authfile "${PULL_SECRET_PATH}" --rm --network=host \🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh` around lines 9 - 35, The remote heredoc contains an unnecessary trace toggle: remove the lone "set +x" after "set -euo pipefail" in the remote script (inside the ssh heredoc) because there is no matching "set -x" or need to disable tracing; update the block that sets TEST/E2E_*/OSAC_TEST_IMAGE and the podman run invocation accordingly by deleting the "set +x" line to clean up the script.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh`:
- Around line 9-35: The remote heredoc contains an unnecessary trace toggle:
remove the lone "set +x" after "set -euo pipefail" in the remote script (inside
the ssh heredoc) because there is no matching "set -x" or need to disable
tracing; update the block that sets TEST/E2E_*/OSAC_TEST_IMAGE and the podman
run invocation accordingly by deleting the "set +x" line to clean up the script.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3aef4350-03c0-4371-a406-ac9cce877f76
📒 Files selected for processing (6)
ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yamlci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.shci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yamlci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
✅ Files skipped from review due to trivial changes (2)
- ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml
- ci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yaml
afd6d21 to
df1cc26
Compare
|
@omer-vishlitzky: This pull request references MGMT-23721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml (1)
57-200: Consider YAML anchors to reduce duplication.All eight test definitions share identical
ASSISTED_CONFIGblocks. Using YAML anchors would reduce maintenance burden and ensure consistency when updating shared configuration.♻️ Example using YAML anchors
# Define anchor at first usage tests: - as: e2e-metal-vmaas-compute-instance-creation capabilities: - intranet cron: 0 2 * * 1 steps: cluster_profile: packet-assisted env: ASSISTED_CONFIG: &assisted-config | OLM_OPERATORS=cnv NUM_MASTERS=1 NUM_WORKERS=0 MASTER_MEMORY=57344 MASTER_DISK_COUNT=2 MASTER_DISK=200000000000 MASTER_CPU=24 OPENSHIFT_VERSION=4.20 TEST: test_compute_instance_lifecycle workflow: osac-project-ofcir-baremetal # Reference anchor in subsequent tests - as: e2e-metal-vmaas-compute-instance-api-fields capabilities: - intranet cron: 0 6 * * 1 steps: cluster_profile: packet-assisted env: ASSISTED_CONFIG: *assisted-config TEST: test_compute_instance_api_fields workflow: osac-project-ofcir-baremetal🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml` around lines 57 - 200, Multiple test job entries repeat the identical ASSISTED_CONFIG block; define a YAML anchor for that block and reuse it to eliminate duplication. Locate the repeated ASSISTED_CONFIG scalar in the test definitions (entries identified by the as values like e2e-metal-vmaas-compute-instance-creation, e2e-metal-vmaas-compute-instance-api-fields, etc.), create a single anchor (e.g., &assisted-config) where it first appears, and replace subsequent ASSISTED_CONFIG blocks with the anchor reference (*assisted-config) in each job’s steps.env to keep TEST and other unique fields unchanged.ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml (1)
1-657: Consider regenerating this file with prowgen.The jobs have the label
ci.openshift.io/generator: prowgen, indicating they should be generated from the ci-operator config. Manual editing of generated files risks drift between the config and job definitions. Runmake jobsor the appropriate prowgen command to regenerate.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml` around lines 1 - 657, The periodic jobs in this YAML appear to be generated (they contain the label ci.openshift.io/generator: prowgen) but were edited manually; regenerate the jobs from the ci-operator config instead of hand-editing to prevent drift: run the repo's job generation (e.g. make jobs or the project's prowgen command) and reapply the generated output so names like periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-api-fields and other periodic-ci-osac-project-osac-test-infra-main-* entries are produced from source; if you intentionally made a one-off change, revert manual edits and update the ci-operator config that drives prowgen so the change is persisted in generation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml`:
- Around line 45-83: The container mounts /secrets/gcs via a volumeMount named
gcs-credentials but no corresponding volume is defined; add a volumes entry
named gcs-credentials to each of the eight periodic job specs (the same files
referencing volumeMounts) with a secret source, e.g. add under volumes: - name:
gcs-credentials secret: secretName: gcs-credentials (or include items if
specific key/path required) so the mount name gcs-credentials in the container
matches an actual volume definition.
---
Nitpick comments:
In
`@ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml`:
- Around line 57-200: Multiple test job entries repeat the identical
ASSISTED_CONFIG block; define a YAML anchor for that block and reuse it to
eliminate duplication. Locate the repeated ASSISTED_CONFIG scalar in the test
definitions (entries identified by the as values like
e2e-metal-vmaas-compute-instance-creation,
e2e-metal-vmaas-compute-instance-api-fields, etc.), create a single anchor
(e.g., &assisted-config) where it first appears, and replace subsequent
ASSISTED_CONFIG blocks with the anchor reference (*assisted-config) in each
job’s steps.env to keep TEST and other unique fields unchanged.
In
`@ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml`:
- Around line 1-657: The periodic jobs in this YAML appear to be generated (they
contain the label ci.openshift.io/generator: prowgen) but were edited manually;
regenerate the jobs from the ci-operator config instead of hand-editing to
prevent drift: run the repo's job generation (e.g. make jobs or the project's
prowgen command) and reapply the generated output so names like
periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-api-fields
and other periodic-ci-osac-project-osac-test-infra-main-* entries are produced
from source; if you intentionally made a one-off change, revert manual edits and
update the ci-operator config that drives prowgen so the change is persisted in
generation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5fbe27a8-fdfc-482e-a84d-5c0cb7956276
📒 Files selected for processing (6)
ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yamlci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.shci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yamlci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
✅ Files skipped from review due to trivial changes (1)
- ci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml
- ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.sh
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
df1cc26 to
1ef2b48
Compare
|
@omer-vishlitzky: This pull request references MGMT-23721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
ci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-presubmits.yaml (1)
48-86:⚠️ Potential issue | 🔴 CriticalThe new e2e presubmits are also missing
gcs-credentials.This container mounts
/secrets/gcsat Lines 55-57 and pointsci-operatorat/secrets/gcs/service-account.json, but the volumes list in Lines 68-86 never definesgcs-credentials. The same pod template is reused for the rest of the new VMaaS presubmits, so they will all fail before execution.Suggested fix
- name: ci-pull-credentials secret: secretName: ci-pull-credentials + - name: gcs-credentials + secret: + secretName: gce-sa-credentials-gcs-publisher - name: manifest-tool-local-pusher secret: secretName: manifest-tool-local-pusher🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-presubmits.yaml` around lines 48 - 86, The pod template mounts /secrets/gcs (volumeMount name gcs-credentials) but the volumes list lacks a matching volume; add a volume entry named gcs-credentials under volumes (similar to ci-pull-credentials or manifest-tool-local-pusher) that references the GCS secret (e.g., secretName: gcs-credentials and include the service-account.json item if needed) so the container can access /secrets/gcs/service-account.json when running as serviceAccountName ci-operator.ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml (1)
45-83:⚠️ Potential issue | 🔴 CriticalAdd the missing
gcs-credentialsvolume.The container mounts
gcs-credentialsat Lines 52-54 and passes--gcs-upload-secret=/secrets/gcs/service-account.json, but there is no matching volume in Lines 65-83. The same pod template is copied into the other seven periodic jobs below, so all of them will fail pod creation beforeci-operatorstarts.Suggested fix
- name: ci-pull-credentials secret: secretName: ci-pull-credentials + - name: gcs-credentials + secret: + secretName: gce-sa-credentials-gcs-publisher - name: manifest-tool-local-pusher secret: secretName: manifest-tool-local-pusher🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml` around lines 45 - 83, The pod template mounts /secrets/gcs as name gcs-credentials and the container uses --gcs-upload-secret=/secrets/gcs/service-account.json but there is no corresponding volume in the volumes list; add a volume entry with name: gcs-credentials that references the Kubernetes Secret (e.g., secretName: gcs-credentials) so the mountPath has backing data (optionally include items mapping key/service-account.json if the secret key differs); update the volumes section alongside existing entries (boskos, ci-pull-credentials, manifest-tool-local-pusher, pull-secret, result-aggregator).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml`:
- Around line 179-196: The TEST env in the job definition for as:
e2e-metal-vmaas-compute-instance-restart-negative is using the wrong selector
(test_compute_instance_restart_negative) and should match the osac-test-infra
job; update the TEST value in that job's env block to
test_compute_instance_restart_past_timestamp_ignored so installer and test-infra
exercise the same scenario (look for the job with as:
e2e-metal-vmaas-compute-instance-restart-negative and change the TEST variable
accordingly).
- Around line 125-142: The TEST env value is pointing at the wrong test
selector; update the TEST environment variable from
test_compute_instance_cli_fields to test_compute_instance_cli_explicit_fields so
the job's CLI selector matches the OSAC_TEST_IMAGE used by the osac-test-infra
suite (ensure any references to test_compute_instance_cli_fields in this job’s
env block are replaced with test_compute_instance_cli_explicit_fields to align
selectors).
In
`@ci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yaml`:
- Around line 39-42: The images block currently builds the osac-test-infra image
but does not promote it, so downstream repos pulling
osac-project/osac-test-infra:latest will get stale/missing tags; add a promotion
block for the image named "osac-test-infra" in the same config (under
images.items / image stream) that publishes the built image to the shared
repository (e.g., set promotion: { name: "osac-test-infra", tag: "latest", to:
"ocp", ... } or equivalent per ci-operator schema), ensuring the merge job
updates the :latest tag used by osac-installer; update the config section around
images/items and the image entry for osac-test-infra to include the promotion
stanza.
---
Duplicate comments:
In
`@ci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-presubmits.yaml`:
- Around line 48-86: The pod template mounts /secrets/gcs (volumeMount name
gcs-credentials) but the volumes list lacks a matching volume; add a volume
entry named gcs-credentials under volumes (similar to ci-pull-credentials or
manifest-tool-local-pusher) that references the GCS secret (e.g., secretName:
gcs-credentials and include the service-account.json item if needed) so the
container can access /secrets/gcs/service-account.json when running as
serviceAccountName ci-operator.
In
`@ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yaml`:
- Around line 45-83: The pod template mounts /secrets/gcs as name
gcs-credentials and the container uses
--gcs-upload-secret=/secrets/gcs/service-account.json but there is no
corresponding volume in the volumes list; add a volume entry with name:
gcs-credentials that references the Kubernetes Secret (e.g., secretName:
gcs-credentials) so the mountPath has backing data (optionally include items
mapping key/service-account.json if the secret key differs); update the volumes
section alongside existing entries (boskos, ci-pull-credentials,
manifest-tool-local-pusher, pull-secret, result-aggregator).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fa67aad0-b57c-454a-b546-0fbb773a3773
📒 Files selected for processing (9)
ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yamlci-operator/config/osac-project/osac-test-infra/osac-project-osac-test-infra-main.yamlci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-postsubmits.yamlci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-presubmits.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-periodics.yamlci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yamlci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-commands.shci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yamlci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
✅ Files skipped from review due to trivial changes (3)
- ci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml
- ci-operator/jobs/osac-project/osac-installer/osac-project-osac-installer-main-postsubmits.yaml
- ci-operator/step-registry/osac-project/baremetal/test/osac-project-baremetal-test-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/jobs/osac-project/osac-test-infra/osac-project-osac-test-infra-main-presubmits.yaml
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
6 similar comments
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
@omer-vishlitzky: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on.
342f1e3 to
becfc3c
Compare
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait.
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@omer-vishlitzky: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
28a0c7b to
d6783dd
Compare
|
/pj-rehearse periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-cli-fields periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-restart-negative periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-subnet-lifecycle periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-api-fields periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-virtual-network-lifecycle periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-restart periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-delete-during-provision periodic-ci-osac-project-osac-test-infra-main-e2e-metal-vmaas-compute-instance-creation |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
* MGMT-23721: add VMaaS periodic E2E jobs to Prow * MGMT-23721: fix KUBECONFIG dir and missing default StorageClass On the ci_machine, $KUBECONFIG points to a directory, not a file. Resolve it to the actual file and export so all subsequent oc commands work. Restore the lvms-vg1 default StorageClass annotation that keycloak's PVC depends on. * MGMT-23721: wait for CNV readiness before OSAC setup Pass VIRT_SERVICE=true so setup.sh waits for HyperConverged to be fully ready before installing cert-manager. Without this, cert-manager installation races with CNV sub-operator reconciliation and occasionally times out. Increase SSH timeout from 60m to 120m to accommodate the additional CNV readiness wait. * MGMT-23721: use file-based TEST names to avoid SSH argument splitting SSH flattens positional arguments into a single string (RFC 4254), so TEST values with spaces (e.g. "test_compute_instance_restart and not negative") get split, shifting all subsequent arguments. Switch all TEST values to use pytest file names (e.g. test_compute_instance_restart.py) which are unique, have no spaces, and match exactly one test module each.
3 participants
https://redhat.atlassian.net/browse/MGMT-23721
Add 8 periodic VMaaS E2E jobs to Prow, one per test:
Schedule: spread across Mon-Thu at 02:00/06:00 UTC.
Uses the existing
osac-project-ofcir-baremetalworkflow withOLM_OPERATORS=cnv.Summary by CodeRabbit