Skip to content

Conversation

@jstuever
Copy link
Contributor

@jstuever jstuever commented Mar 18, 2020

This change follows up on openshift/installer#3309; and tests the changes it makes. This PR will not pass until 3309 has merged because the bootstrap instance group is needed for these changes to work.

@jstuever
Copy link
Contributor Author

/hold for e2e-gcp-upi

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@jstuever
Copy link
Contributor Author

/assign @abhinavdahiya

@jstuever
Copy link
Contributor Author

/test pj-rehearse

3 similar comments
@jstuever
Copy link
Contributor Author

/test pj-rehearse

@jstuever
Copy link
Contributor Author

/test pj-rehearse

@jstuever
Copy link
Contributor Author

/test pj-rehearse

@jstuever
Copy link
Contributor Author

/test pj-rehearse
There were concurrent policy changes

@jstuever
Copy link
Contributor Author

/test pj-rehearse

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@jstuever
Copy link
Contributor Author

/hold cancel
e2e-gcp-upi success. All code is in =="gcp" blocks.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a2be188 into openshift:master Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

@jstuever: Updated the following 5 configmaps:

  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
  • prow-job-cluster-launch-installer-upi-e2e configmap in namespace ci at cluster app.ci using the following files:
    • key cluster-launch-installer-upi-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-upi-e2e.yaml
Details

In response to this:

This change follows up on openshift/installer#3309; and tests the changes it makes. This PR will not pass until 3309 has merged because the bootstrap instance group is needed for these changes to work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-azure-upi 5cb68c6 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi 5cb68c6 link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere 5cb68c6 link /test pj-rehearse
ci/prow/pj-rehearse 5cb68c6 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever jstuever deleted the cors1396 branch February 11, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants