Skip to content

Reintroduce bare ipi workflow as ipi-aws #7734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 18, 2020
Merged

Reintroduce bare ipi workflow as ipi-aws #7734

openshift-merge-robot merged 1 commit into from
Mar 18, 2020

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Mar 17, 2020

The ipi workfow was removed in #7625. The workflow that allows custom test injection is still useful, and it is used by experimental optional operator testing jobs from r-o-e/release: https://github.com/redhat-operator-ecosystem/release/blob/master/ci-operator/config/redhat-operator-ecosystem/playground/redhat-operator-ecosystem-playground-cvp-ocp-4.5.yaml

/cc @stevekuznetsov @wking @bbguimaraes

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
petr-muller added a commit to petr-muller/rh-op-ecosystem-release that referenced this pull request Mar 17, 2020
@petr-muller
Use AWS-specific workflow in CVP tests
7ba4af3 
The `ipi` workflow was removed in
openshift/release#7625 and is reintroduced as
`ipi-aws` in openshift/release#7734 (hopefully).
So retarget the AWS test to the `ipi-aws` workflow, and for now delete
the GCP test because it does not have its workflow yet.
@petr-muller petr-muller mentioned this pull request Mar 17, 2020
Merged
@bbguimaraes
Copy link
Contributor

bbguimaraes commented Mar 18, 2020

The same could still be achieved by using origin-e2e-aws and replacing the test section, but a separate workflow is clearer IMO.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8b741ad into openshift:master Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2020

@petr-muller: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/aws/OWNERS
    • key ipi-aws-workflow.yaml using file ci-operator/step-registry/ipi/aws/ipi-aws-workflow.yaml
  • step-registry configmap in namespace ci at cluster default using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/aws/OWNERS
    • key ipi-aws-workflow.yaml using file ci-operator/step-registry/ipi/aws/ipi-aws-workflow.yaml
Details

In response to this:

The ipi workfow was removed in #7625. The workflow that allows custom test injection is still useful, and it is used by experimental optional operator testing jobs from r-o-e/release: https://github.com/redhat-operator-ecosystem/release/blob/master/ci-operator/config/redhat-operator-ecosystem/playground/redhat-operator-ecosystem-playground-cvp-ocp-4.5.yaml

/cc @stevekuznetsov @wking @bbguimaraes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller
Copy link
Member Author

petr-muller commented Mar 18, 2020

The same could still be achieved by using origin-e2e-aws and replacing the test section, but a separate workflow is clearer IMO.

Oh, I did not know replacing sections when using a workflow is even possible, thanks!

@bbguimaraes
Copy link
Contributor

bbguimaraes commented Mar 18, 2020

https://steps.svc.ci.openshift.org/help#config

The example there makes some sense (replacing the test section in origin-e2e with origin-e2e-minimal), but in your case I think using the generic, test-less workflow is clearer even though it is semantically equivalent.

petr-muller added a commit to petr-muller/rh-op-ecosystem-release that referenced this pull request Mar 18, 2020
@petr-muller
Use AWS-specific workflow in CVP tests
743299f 
The `ipi` workflow was removed in
openshift/release#7625 and is reintroduced as
`ipi-aws` in openshift/release#7734 (hopefully).
So retarget the AWS test to the `ipi-aws` workflow, and for now delete
the GCP test because it does not have its workflow yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@wking wking Awaiting requested review from wking

Assignees

@bbguimaraes bbguimaraes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petr-muller @bbguimaraes @openshift-ci-robot @openshift-merge-robot