Skip to content

Add e2e-metal-ipi CI job #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 18, 2020
Merged

Add e2e-metal-ipi CI job #7727

openshift-merge-robot merged 1 commit into from
Mar 18, 2020

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 17, 2020

No description provided.

@stbenjam
Copy link
Member Author

stbenjam commented Mar 17, 2020

/test generated-config

russellb
russellb reviewed Mar 17, 2020
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml Outdated
Copy link
Contributor

@russellb russellb Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the name that's visible to users something like e2e-metal-ipi ? I don't think baremetalds is going to be meaningful to most people

@stbenjam
Copy link
Member Author

stbenjam commented Mar 17, 2020

/test pj-rehearse

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/test pj-rehearse

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/test pj-rehearse

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/hold

Still need to address naming, but at least job is running

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@andfasano
Copy link
Contributor

andfasano commented Mar 18, 2020

/test pj-rehearse

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/retitle Add e2e-metal-ipi CI job

@openshift-ci-robot openshift-ci-robot changed the title Add e2e-baremetalds CI job Add e2e-metal-ipi CI job Mar 18, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/hold cancel

This should be good to go.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
@derekhiggins derekhiggins mentioned this pull request Mar 18, 2020
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2020

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-metal-ipi 7fab05b link /test pj-rehearse
ci/prow/pj-rehearse 7fab05b link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

/assign @crawford

@crawford
Copy link
Contributor

crawford commented Mar 18, 2020

The tests are still failing and while digging into the exact failure, I wasn't able to find the typical set of artifacts that are saved when creating a cluster. Did I miss something?

@stbenjam
Copy link
Member Author

stbenjam commented Mar 18, 2020

The tests are still failing and while digging into the exact failure, I wasn't able to find the typical set of artifacts that are saved when creating a cluster. Did I miss something?

We can't use the step-registry gather step and have to write one, it's in progress. We don't want it to hold up this job.

The failure's expected at this point, baremetal IPI deploys have been flakey over the last week - we're digging into it, but even getting the jobs in place in the state they are can be valuable for preventing regressions on IPv6, etc. We don't expect it to be blocking on anything until it's stable.

@crawford
Copy link
Contributor

crawford commented Mar 18, 2020

I see, this uses the "new" step/chain/workflow mechanism. I need to familiarize myself with the new paradigm. This looks fine.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit c6b6277 into openshift:master Mar 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2020

@stbenjam: Updated the following 7 configmaps:

  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akiselev1 akiselev1 mentioned this pull request Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

1 more reviewer

@russellb russellb russellb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stbenjam @andfasano @openshift-ci-robot @crawford @russellb @openshift-merge-robot