CNTRLPLANE-2561: Add automated PR review comment handling for HyperShift - #73642
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@bryan-cox: This pull request references CNTRLPLANE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@bryan-cox: This pull request references CNTRLPLANE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
b1becbc to
3465b41
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dbf2c13 to
baefcd3
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…s format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
/pj-rehearse ack |
|
@csrwng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ift (openshift#73642) * feat(step-registry): Add hypershift-review-agent workflow Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(step-registry): hypershift-review-agent OWNERS parsing for filters format The authorization check was failing for users like jparrill who are listed in OWNERS_ALIASES but not recognized because the OWNERS file uses a filters-based format instead of simple top-level lists. Changes: - Replace get_owners_and_aliases() and is_in_owners_file() with a single get_all_authorized_users() function that builds one combined set - Add all users from all aliases in OWNERS_ALIASES upfront - Parse both simple format (top-level approvers/reviewers) and filters-based format (nested under filters key) - Simplify is_authorized_author() to check combined set then fallback to org membership Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
5 participants
Summary
Adds the HyperShift Review Agent workflow - an automated system that uses Claude Code to address PR review comments on PRs created by the HyperShift Jira Agent.
What This PR Adds
Step Registry Workflow
hypershift-review-agentworkflow with setup and process stepsapp/hypershift-jira-solve-ciCI Jobs
periodic-review-agentreview-agent-single-pr/test review-agent-single-prConfiguration
claude-ai-helperscontainer imageREVIEW_AGENT_MAX_PRS)Files Changed
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml- Job definitionsci-operator/step-registry/hypershift/review-agent/- New workflow and step definitionsci-operator/jobs/openshift/hypershift/- Generated Prow jobs🤖 Generated with Claude Code