Enable approve and lgtm plugins for terraform-windows-provisioner

[rrasouli]

Summary

Enable Prow approve plugin for the openshift/terraform-windows-provisioner repository to allow maintainers to use the /approve command.

Background

The terraform-windows-provisioner repository currently has /lgtm working (enabled globally for openshift org) but /approve is not functional because the approve plugin is not configured for this specific repository.

This causes issues where PRs cannot be automatically merged even when all requirements are met, as the "approved" label cannot be added via the /approve command.

Changes

• Add _pluginconfig.yaml for openshift/terraform-windows-provisioner
• Enable approve plugin with standard configuration
• Configure lgtm settings with review_acts_as_lgtm: true
• Set lgtm_acts_as_approve: false to require explicit approval

Note: The lgtm plugin itself is NOT added to the plugins list as it's already enabled globally for the openshift organization. Only the approve plugin is explicitly enabled.

Configuration Details

approve:
- commandHelpLink: ""
  lgtm_acts_as_approve: false
  repos:
  - openshift/terraform-windows-provisioner
  require_self_approval: false
lgtm:
- repos:
  - openshift/terraform-windows-provisioner
  review_acts_as_lgtm: true
plugins:
  openshift/terraform-windows-provisioner:
    plugins:
    - approve

Testing

After this PR is merged:

1. Maintainers listed in the OWNERS file can use /approve to add the "approved" label
2. The /lgtm command will continue to work as before (globally enabled)
3. PRs with both "lgtm" and "approved" labels can be automatically merged by Tide

Related

• Repository: https://github.com/openshift/terraform-windows-provisioner
• Example PR waiting for approval: Transform into vendor-neutral upstream project with zero hardcoded values terraform-windows-provisioner#6

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@rrasouli: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[rrasouli]

/lgtm

[openshift-ci]

@rrasouli: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[deepsm007]

/test check-gh-automation-tide

[rrasouli]

@deepsm007 Can you review please , openshift/terraform-windows-provisioner#6 can't be merged and is missing approve label

[deepsm007]

@deepsm007 Can you review please , openshift/terraform-windows-provisioner#6 can't be merged and is missing approve label

@rrasouli You have to reach out to repo owners for ^ PR

[rrasouli]

@deepsm007 Can you review please , openshift/terraform-windows-provisioner#6 can't be merged and is missing approve label

@rrasouli You have to reach out to repo owners for ^ PR

@deepsm007 I am the repo owner for terraform-windows-provisioner (see OWNERS file: https://github.com/openshift/terraform-windows-provisioner/blob/main/OWNERS).
The issue is that the /approve command doesn't work on that repo because the approve plugin isn't configured in Prow yet - that's exactly what this PR fixes.
Once this PR merges, I'll be able to use /approve on PR #6.
Could you please review this PR and add /lgtm if it looks good?

[deepsm007]

/retest
/lgtm
the failure was related to incorrect token in ci for pulling quay images. Updated the token and restarted the pod.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, rrasouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rrasouli]

/pj-rehearse skip

[openshift-ci-robot]

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[rrasouli]

/retest ci/prow/check-gh-automation-tide

[openshift-ci]

@rrasouli: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test app-ci-config-dry

/test boskos-config

/test boskos-config-generation

/test build01-dry

/test build02-dry

/test build03-dry

/test build04-dry

/test build06-dry

/test build07-dry

/test build08-dry

/test build09-dry

/test build10-dry

/test check-gh-automation

/test check-gh-automation-tide

/test ci-operator-config

/test ci-operator-config-metadata

/test ci-operator-registry

/test ci-secret-bootstrap-config-validation

/test ci-testgrid-allow-list

/test clusterimageset-validate

/test config

/test core-ci-config-dry

/test core-valid

/test generated-config

/test generated-dashboards

/test hosted-mgmt-dry

/test image-mirroring-config-validation

/test jira-lifecycle-config

/test labels

/test openshift-image-mirror-mappings

/test ordered-prow-config

/test owners

/test pr-reminder-config

/test prow-config

/test prow-config-filenames

/test prow-config-semantics

/test pylint

/test release-config

/test release-controller-config

/test rover-groups-config-validation

/test secret-generator-config-valid

/test services-valid

/test stackrox-stackrox-stackrox-stackrox-check

/test step-registry-metadata

/test step-registry-shellcheck

/test sync-rover-groups

/test verified-config

/test vsphere02-dry

/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry

/test build11-dry

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation-tide

pull-ci-openshift-release-master-boskos-config-generation

pull-ci-openshift-release-master-config

pull-ci-openshift-release-master-core-valid

pull-ci-openshift-release-master-owners

pull-ci-openshift-release-master-prow-config

pull-ci-openshift-release-master-release-controller-config

pull-ci-openshift-release-openshift-image-mirror-mappings

pull-ci-openshift-release-yamllint

Details

In response to this:

/retest ci/prow/check-gh-automation-tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rrasouli]

/retest check-gh-automation-tide

[openshift-ci]

@rrasouli: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test app-ci-config-dry

/test boskos-config

/test boskos-config-generation

/test build01-dry

/test build02-dry

/test build03-dry

/test build04-dry

/test build06-dry

/test build07-dry

/test build08-dry

/test build09-dry

/test build10-dry

/test check-gh-automation

/test check-gh-automation-tide

/test ci-operator-config

/test ci-operator-config-metadata

/test ci-operator-registry

/test ci-secret-bootstrap-config-validation

/test ci-testgrid-allow-list

/test clusterimageset-validate

/test config

/test core-ci-config-dry

/test core-valid

/test generated-config

/test generated-dashboards

/test hosted-mgmt-dry

/test image-mirroring-config-validation

/test jira-lifecycle-config

/test labels

/test openshift-image-mirror-mappings

/test ordered-prow-config

/test owners

/test pr-reminder-config

/test prow-config

/test prow-config-filenames

/test prow-config-semantics

/test pylint

/test release-config

/test release-controller-config

/test rover-groups-config-validation

/test secret-generator-config-valid

/test services-valid

/test stackrox-stackrox-stackrox-stackrox-check

/test step-registry-metadata

/test step-registry-shellcheck

/test sync-rover-groups

/test verified-config

/test vsphere02-dry

/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry

/test build11-dry

/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation-tide

pull-ci-openshift-release-master-boskos-config-generation

pull-ci-openshift-release-master-config

pull-ci-openshift-release-master-core-valid

pull-ci-openshift-release-master-owners

pull-ci-openshift-release-master-prow-config

pull-ci-openshift-release-master-release-controller-config

pull-ci-openshift-release-openshift-image-mirror-mappings

pull-ci-openshift-release-yamllint

Details

In response to this:

/retest check-gh-automation-tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rrasouli]

/test check-gh-automation-tide

[deepsm007]

/override ci/prow/check-gh-automation-tide

[openshift-ci]

@deepsm007: Overrode contexts on behalf of deepsm007: ci/prow/check-gh-automation-tide

Details

In response to this:

/override ci/prow/check-gh-automation-tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@rrasouli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@rrasouli: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

• key core-services-prow-02_config-openshift-terraform-windows-provisioner-_pluginconfig.yaml using file core-services/prow/02_config/openshift/terraform-windows-provisioner/_pluginconfig.yaml

Details

In response to this:

Summary

Enable Prow approve plugin for the openshift/terraform-windows-provisioner repository to allow maintainers to use the /approve command.

Background

The terraform-windows-provisioner repository currently has /lgtm working (enabled globally for openshift org) but /approve is not functional because the approve plugin is not configured for this specific repository.

This causes issues where PRs cannot be automatically merged even when all requirements are met, as the "approved" label cannot be added via the /approve command.

Changes

• Add _pluginconfig.yaml for openshift/terraform-windows-provisioner
• Enable approve plugin with standard configuration
• Configure lgtm settings with review_acts_as_lgtm: true
• Set lgtm_acts_as_approve: false to require explicit approval

Note: The lgtm plugin itself is NOT added to the plugins list as it's already enabled globally for the openshift organization. Only the approve plugin is explicitly enabled.

Configuration Details

approve:
- commandHelpLink: ""
 lgtm_acts_as_approve: false
 repos:
 - openshift/terraform-windows-provisioner
 require_self_approval: false
lgtm:
- repos:
 - openshift/terraform-windows-provisioner
 review_acts_as_lgtm: true
plugins:
 openshift/terraform-windows-provisioner:
   plugins:
   - approve

Testing

After this PR is merged:

1. Maintainers listed in the OWNERS file can use /approve to add the "approved" label
2. The /lgtm command will continue to work as before (globally enabled)
3. PRs with both "lgtm" and "approved" labels can be automatically merged by Tide

Related

• Repository: https://github.com/openshift/terraform-windows-provisioner
• Example PR waiting for approval: Transform into vendor-neutral upstream project with zero hardcoded values terraform-windows-provisioner#6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.