Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Nov 26, 2025

Summary

This PR updates the OPCT workflow configuration to use development images from quay.io/mrbraga for testing fixes to CI failures in OCP 4.20+ clusters.

Changes

  • Updated OPCT_CLI_IMAGE to quay.io/mrbraga/opct:spike-420-issues
  • Added OPCT_DEV_EXTRA_CMD with --plugins-image flag pointing to quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

This approach allows testing custom images without modifying pkg/types.go, using the --plugins-image CLI argument instead of hardcoded defaults.

Built Images

  • opct CLI: quay.io/mrbraga/opct:spike-420-issues
  • plugins: quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

Related Fixes Being Tested

  1. Issue #1: Fixed map printing in status utils - opct PR
  2. Issue #2 & #3: Fixed HTML encoding and messages in printer - opct PR
  3. Issue Add the template for the web console #4: Added failure propagation between plugins - plugins PR
  4. Issue #5: Made log level configurable via LOG_LEVEL env var - plugins PR
  5. Issue WIP: config/atomic: Import my Homu work  #6: Fixed time calculation bug in archive metalog - opct PR
  6. Issue React to changes in base origin-gce; make run generic #7: Added k8s conformance test extraction for OCP 4.20+ - opct PR

Testing

This PR enables CI rehearsal testing of all fixes. Once the rehearsal job passes, we can merge the individual fixes to the respective repositories.

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Nov 26, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Nov 26, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 1, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 2, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 2, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 3, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.21-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 3, 2025

opct plugin image expired :(

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.21-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm 6ac0656 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Dec 4, 2025

PRs redhat-openshift-ecosystem/opct#183 (comment) and redhat-openshift-ecosystem/provider-certification-plugins#82 are validated with jobs:

I will notify them for ready for review (OPCT project does not have presubmit, so those rehearsal intends to validate it). Once we have a new release for OPCT I will update this PR for readiness.

Updated OPCT workflow to use development images for testing fixes
to CI failures in OCP 4.20+ clusters.

Changes:
- Updated OPCT_CLI_IMAGE to quay.io/mrbraga/opct:spike-420-issues
- Added OPCT_DEV_EXTRA_CMD with --plugins-image flag pointing to
  quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

This allows testing custom images without modifying pkg/types.go,
using the --plugins-image CLI argument instead of hardcoded defaults.

Built images:
- opct CLI: quay.io/mrbraga/opct:spike-420-issues
- plugins: quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

Related fixes being tested:
- Issue #1: Fixed map printing in status utils
- Issue #2 & #3: Fixed HTML encoding and messages in printer
- Issue openshift#4: Added failure propagation between plugins
- Issue #5: Made log level configurable via LOG_LEVEL env var
- Issue openshift#6: Fixed time calculation bug in archive metalog
- Issue openshift#7: Added k8s conformance test extraction for OCP 4.20+

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

testing with latest opct version

validate 0.6.1
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Dec 6, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.18-opct-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm periodic-ci-openshift-release-master-nightly-4.21-opct-external-aws-ccm

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 6, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: job(s): periodic-ci-openshift-release-master-nightly-4.18-opct-external-aws-ccm, periodic-ci-openshift-release-master-nightly-4.20-opct-external-aws-ccm, periodic-ci-openshift-release-master-nightly-4.21-opct-external-aws-ccm either don't exist or were not found to be affected, and cannot be rehearsed

@mtulio
Copy link
Contributor Author

mtulio commented Dec 6, 2025

/test all

1 similar comment
@mtulio
Copy link
Contributor Author

mtulio commented Dec 6, 2025

/test all

@mtulio
Copy link
Contributor Author

mtulio commented Dec 8, 2025

I dont know why detecting no rehearsals, let me convert to ready to see if bot detects correctly the changes.

@mtulio mtulio marked this pull request as ready for review December 8, 2025 14:17
@openshift-ci openshift-ci bot requested review from elmiko and jcpowermac December 8, 2025 14:17
@mtulio mtulio changed the title WIP/OPCT: investigate job failures on 4.20 plus OPCT: promoting OPCT v0.6.1 Dec 8, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Dec 8, 2025

/hold cancel

@jcpowermac
Copy link
Contributor

/pj-rehearse list

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor

/approve
/lgtm
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtulio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor Author

mtulio commented Dec 8, 2025

Rehearsal jobs weren't detected by CI bot - as expected. We are going to proceed with this PR and keep monitoring the jobs on Slack:
https://redhat.enterprise.slack.com/archives/C064717U0D7
https://redhat.enterprise.slack.com/archives/C04HTQ7A7EX

@openshift-merge-bot openshift-merge-bot bot merged commit 9d69599 into openshift:master Dec 8, 2025
10 checks passed
@mtulio mtulio deleted the spike-420-issues branch December 8, 2025 16:22
dfrazzette pushed a commit to dfrazzette/release that referenced this pull request Dec 9, 2025
* ci: use spike-420-issues images for CI rehearsal validation

Updated OPCT workflow to use development images for testing fixes
to CI failures in OCP 4.20+ clusters.

Changes:
- Updated OPCT_CLI_IMAGE to quay.io/mrbraga/opct:spike-420-issues
- Added OPCT_DEV_EXTRA_CMD with --plugins-image flag pointing to
  quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

This allows testing custom images without modifying pkg/types.go,
using the --plugins-image CLI argument instead of hardcoded defaults.

Built images:
- opct CLI: quay.io/mrbraga/opct:spike-420-issues
- plugins: quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

Related fixes being tested:
- Issue #1: Fixed map printing in status utils
- Issue #2 & #3: Fixed HTML encoding and messages in printer
- Issue openshift#4: Added failure propagation between plugins
- Issue #5: Made log level configurable via LOG_LEVEL env var
- Issue openshift#6: Fixed time calculation bug in archive metalog
- Issue openshift#7: Added k8s conformance test extraction for OCP 4.20+

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

testing with latest opct version

validate 0.6.1

* Removing changes in AI workflow as is not monitored by SPLAT
eifrach pushed a commit to eifrach/release that referenced this pull request Dec 16, 2025
* ci: use spike-420-issues images for CI rehearsal validation

Updated OPCT workflow to use development images for testing fixes
to CI failures in OCP 4.20+ clusters.

Changes:
- Updated OPCT_CLI_IMAGE to quay.io/mrbraga/opct:spike-420-issues
- Added OPCT_DEV_EXTRA_CMD with --plugins-image flag pointing to
  quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

This allows testing custom images without modifying pkg/types.go,
using the --plugins-image CLI argument instead of hardcoded defaults.

Built images:
- opct CLI: quay.io/mrbraga/opct:spike-420-issues
- plugins: quay.io/mrbraga/plugin-openshift-tests:spike-420-issues-buildx

Related fixes being tested:
- Issue #1: Fixed map printing in status utils
- Issue #2 & #3: Fixed HTML encoding and messages in printer
- Issue openshift#4: Added failure propagation between plugins
- Issue #5: Made log level configurable via LOG_LEVEL env var
- Issue openshift#6: Fixed time calculation bug in archive metalog
- Issue openshift#7: Added k8s conformance test extraction for OCP 4.20+

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

testing with latest opct version

validate 0.6.1

* Removing changes in AI workflow as is not monitored by SPLAT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants