Skip to content

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Nov 24, 2025

  • remove feature gate GCPCustomAPIEndpointsInstall
  • move gather-proxy to after ipi-deprovision

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-gcp

@openshift-ci-robot
Copy link
Contributor

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianli-wei jianli-wei force-pushed the gcp-debug branch 3 times, most recently from 508e923 to b9764e6 Compare November 24, 2025 06:12
@jianli-wei jianli-wei changed the title WIP: gcp custom endpoint without feature gate WIP: remove feature gate for gcp custom endpoint tests Nov 24, 2025
@jianli-wei jianli-wei changed the title WIP: remove feature gate for gcp custom endpoint tests WIP: remove feature gate for gcp-ipi-custom-endpoint tests Nov 24, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianli-wei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-custom-endpoint-mini-perm-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-custom-endpoint-mini-perm-arm-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-custom-endpoint-proxy-oidc-mini-amd-f28-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-gcp-ipi-custom-endpoint-proxy-oidc-mini-perm-arm-f14 N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-gcp N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-gcp-proxy N/A periodic Ci-operator config changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-gcp-ipi-custom-endpoint-proxy-users-static-mini-perm-f28 N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-main-installer-rehearse-4.21-installer-rehearse-gcp-proxy

@openshift-ci-robot
Copy link
Contributor

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@jianli-wei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jianli-wei jianli-wei changed the title WIP: remove feature gate for gcp-ipi-custom-endpoint tests remove feature gate for gcp-ipi-custom-endpoint tests Nov 24, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@jianli-wei
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianli-wei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 24, 2025
@jianli-wei
Copy link
Contributor Author

@gpei @yunjiang29 please help review, thanks!

@gpei
Copy link
Contributor

gpei commented Nov 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@jianli-wei
Copy link
Contributor Author

@liangxia please help review, thanks!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, jianli-wei, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 427b311 into openshift:master Nov 25, 2025
18 checks passed
@jianli-wei jianli-wei deleted the gcp-debug branch November 25, 2025 07:03
dfrazzette pushed a commit to dfrazzette/release that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants