Skip to content

Conversation

@DavidHurta
Copy link
Contributor

@DavidHurta DavidHurta commented Oct 13, 2025

The golangci-lint support for go1.24 was introduced in v1.64.2 [1]

Needed for a go bump in openshift/cluster-version-operator#1247.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@openshift-ci openshift-ci bot requested review from hongkailiu and wking October 13, 2025 15:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-release-4.20-lint

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta DavidHurta force-pushed the cvo-bump-golangci-lint-4-20 branch from bcec5a9 to 7bd73ba Compare October 13, 2025 16:12
@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-release-4.20-lint

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta DavidHurta force-pushed the cvo-bump-golangci-lint-4-20 branch from 7bd73ba to 0109cef Compare October 13, 2025 16:31
@DavidHurta
Copy link
Contributor Author

TIL: the existing versions can be viewed here

@DavidHurta
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-release-4.20-lint

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DavidHurta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-operator openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-operator-devpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-operator-techpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-ovn openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-ovn-upgrade-into-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-ovn-upgrade-into-change-techpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-ovn-upgrade-out-of-change openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-agnostic-ovn-upgrade-out-of-change-techpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-aws-ovn-techpreview openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-extended-tests openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-hypershift openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-e2e-hypershift-conformance openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-gofmt openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-images openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-lint openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-okd-scos-e2e-aws-ovn openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-okd-scos-images openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-unit openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-verify-deps openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-verify-update openshift/cluster-version-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-version-operator-release-4.20-verify-yaml openshift/cluster-version-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@DavidHurta DavidHurta changed the title WIP: cvo: Bump golangci-lint to support go1.24 in 4.20 NO-JIRA: CVO: Bump golangci-lint to support go1.24 in 4.20 Oct 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 14, 2025
@openshift-ci-robot
Copy link
Contributor

@DavidHurta: This pull request explicitly references no jira issue.

Details

In response to this:

golangci-lint support for go1.24 introduced in v1.64.2 [1]

Needed for a go bump in openshift/cluster-version-operator#1247.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@DavidHurta
Copy link
Contributor Author

The lint job is the only job that uses the image.

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@DavidHurta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 14, 2025
@hongkailiu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@DavidHurta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d1d0d0e into openshift:master Oct 14, 2025
14 checks passed
tbuskey pushed a commit to tbuskey/release that referenced this pull request Oct 14, 2025
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants