SPLAT-2501: remove duplicated feature set configuration

[mtulio]

The recently change #69181 introduced techpreview jobs and workflow by configuring feature set as env var in the job level on install time, this PR proposes to ensure that the Feature Set TechPreviewNoUpgrade is set in the workflow level to follow it's name, removing duplicated steps.

Refs:

• SPLAT-2337: tests/ote: Introduce openshift test extension binary cloud-provider-aws#117
• https://issues.redhat.com/browse/SPLAT-2501

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-techpreview	openshift/cloud-provider-aws	presubmit	Ci-operator config changed
pull-ci-openshift-cloud-provider-aws-release-4.22-e2e-aws-ovn-techpreview	openshift/cloud-provider-aws	presubmit	Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.21-e2e-aws-ovn-techpreview	openshift/cloud-provider-aws	presubmit	Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-techpreview	openshift/cluster-cloud-controller-manager-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.22-e2e-aws-ovn-techpreview	openshift/cluster-cloud-controller-manager-operator	presubmit	Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.21-e2e-aws-ovn-techpreview	openshift/cluster-cloud-controller-manager-operator	presubmit	Registry content changed
periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[mtulio]

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview

[openshift-ci-robot]

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mtulio]

/pj-rehearse pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-techpreview

[openshift-ci-robot]

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mtulio]

/test all

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Details

In response to this:

The recently introduce techpreview workflow already sets the feature set as env var in the job level on install time, this PR proposes to ensure that the Feature Set TechPreviewNoUpgrade is set in the workflow level to follow it's name, removing duplicated steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mtulio, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout e0fa261a5a07e7a1e891b0d29b8da350aa309a9f]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Details

In response to this:

The recently change #69181 introduced techpreview jobs and workflow by configuring feature set as env var in the job level on install time, this PR proposes to ensure that the Feature Set TechPreviewNoUpgrade is set in the workflow level to follow it's name, removing duplicated steps.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

/pj-rehearse pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-techpreview

[openshift-ci-robot]

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Details

In response to this:

The recently change #69181 introduced techpreview jobs and workflow by configuring feature set as env var in the job level on install time, this PR proposes to ensure that the Feature Set TechPreviewNoUpgrade is set in the workflow level to follow it's name, removing duplicated steps.

Refs:

• SPLAT-2337: tests/ote: Introduce openshift test extension binary cloud-provider-aws#117
• https://issues.redhat.com/browse/SPLAT-2501

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcpowermac]

/lgtm

[damdo]

/approve

[mtulio]

Accepting rehearsal:

• e2e passing
• LB gather is collecting data
• cluster installed with Feature Set TPNU

$ omc get FeatureGate cluster -o yaml | yq ea .spec -
featureSet: TechPreviewNoUpgrade

/pj-rehearse ack

[openshift-ci-robot]

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[mtulio]

PTAL, @vrutkovs ?

/assign @vrutkovs

[vrutkovs]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, jcpowermac, mtulio, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cloud-provider-aws/OWNERS [damdo]
• ci-operator/config/openshift/cluster-cloud-controller-manager-operator/OWNERS [damdo]
• ci-operator/config/openshift/release/OWNERS [vrutkovs]
• ci-operator/step-registry/openshift/e2e/aws/ccm/techpreview/OWNERS [damdo,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment