[CNTRLPLANE-1259]Call OTE in the ci for oauth-apiserver in order to ensure that the tests will be execute always #68202
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,6 +83,20 @@ tests: | |
| CHECK_MOD_LIST: "false" | ||
| test: | ||
| - ref: go-verify-deps | ||
| - as: e2e-tests-extension | ||
| optional: true | ||
| steps: | ||
| test: | ||
| - as: tests-extension | ||
| commands: | | ||
| echo "Build binary oauth-apiserver-tests-ext" | ||
| make tests-ext-build | ||
| echo "Running ./oauth-apiserver-tests-ext with sanity test" | ||
| ./oauth-apiserver-tests-ext run-suite openshift/oauth-apiserver/conformance/parallel -j ${ARTIFACT_DIR}/junit_$(shell date +%Y%m%d-%H%M%S).xml | ||
|
Contributor
There was a problem hiding this comment. shouldn't how do we add tests to a suite for an existing repo ?
Contributor
Author
There was a problem hiding this comment. https://github.com/openshift/oauth-apiserver/blob/34b8999cc261b993cb2a41920f686b88286002d9/test/e2e/tokenreviews.go#L23 is for e2e test, we can see they are in job https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oauth-apiserver/146/pull-ci-openshift-oauth-apiserver-master-e2e-component/ and https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oauth-apiserver/146/pull-ci-openshift-oauth-apiserver-master-unit.
We can add tests into this file https://github.com/openshift/oauth-apiserver/blob/master/test/extended/main.go or some others in directory https://github.com/openshift/oauth-apiserver/blob/master/test/extended, this is the same we did befoe in origin.
Contributor
There was a problem hiding this comment. I think that the idea behind "openshift-tests-extension" is to be able to execute tests defined for a component/repository/operator. In our case it is about executing tests defined in the oauth-apiserver repo. Right? Having said that should tests be added to the defined suites ? Is this something we will be doing in the future?
Contributor
Author
There was a problem hiding this comment. We will add test cases to the corresponding suite based on the test attributes, such as parallel and serial.
Yes, we will add some tests to tests-extension, maybe move some from origin, some from bugs, some from features.
Contributor
There was a problem hiding this comment. The doc you referenced shows that the name of the binary should be
Contributor
Author
There was a problem hiding this comment. no specific convention for the name of the binary, but we use component name of github repo to name, that's easy to manage and identify. From extensionBinaries registry https://github.com/openshift/origin/blob/main/pkg/test/extensions/binary.go#L167, we can see their names are different, but at least components of control plane are unified.
Contributor
There was a problem hiding this comment. should we define a makefile target that would run a default test suite ? by doing so we wouldn't have to change the CI job definition if we wanted to change something.
Contributor
Author
There was a problem hiding this comment.
Our case is executed for oauth-apiserver repo, also register the binary in origin’s extension registry. |
||
| from: src | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| zz_generated_metadata: | ||
| branch: master | ||
| org: openshift | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which test suites should this job be executing ? is there a convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically consistent with the origin we have done before, parallel cases in parallel CI job and serial cases in serial CI job. These will be reflected in the test names, see https://github.com/openshift/oauth-apiserver/blob/master/test/extended/main.go#L9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In conclusion, the CI job name
e2e-tests-extensionhere may not necessarily be the names we will use in the future, maybee2e-tests-extension-aws,e2e-tests-extension-aws-serialare CI job names.