-
Notifications
You must be signed in to change notification settings - Fork 2k
WIP: CNTRLPLANE-945: cao: move external oidc tests from presubmits to periodics #67837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| test: | ||
| - ref: openshift-e2e-test-8h | ||
| workflow: openshift-e2e-aws | ||
| timeout: 8h0m0s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, setting this to the highest possible timeout because they are long running jobs. That being said, it probably makes sense to consider splitting these tests up where possible so we can have much shorter runtimes for the set of tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2963c9c does just this, splitting into logical chunks of tests for the feature, effectively reducing each job runtime to 1/3 of this previous configuration, but introduces 3 times the amount of jobs that run.
I'm not sure which approach is preferred so I'll let others chime in here.
|
Rehearsals will fail until openshift/origin#30040 is included in a payload |
| - as: e2e-vsphere-external-oidc-configure | ||
| interval: 24h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to choose some jobs to cover other ARCH like multi-arch or amd64? I intended to cover it to be tracked in https://issues.redhat.com/browse/AUTH-574 . Happened to see you're adding the vsphere platform jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would have to add those in addition to the ones configured here.
I'm certainly open to it, but this PR is specifically scoped to adding the jobs required to satisfy the OCP feature promotion criteria which does not include arm64 or multi-arch jobs.
I'll do some further exploration and if it is straightforward to add arm64 and/or multi-arch jobs I'll add them. Otherwise, I'll suggest that we add those in a follow-up PR so we can continue making progress towards feature promotion.
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
6a6bf81 to
02666ad
Compare
|
/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview |
|
@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@everettraven: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Obsolete now. Closing. /close |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@everettraven: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.