Skip to content

Conversation

@everettraven
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 5, 2025

@everettraven: This pull request references CNTRLPLANE-945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven
Once this PR has been reviewed and has the lgtm label, please assign liouk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from ibihim and liouk August 5, 2025 17:50
test:
- ref: openshift-e2e-test-8h
workflow: openshift-e2e-aws
timeout: 8h0m0s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, setting this to the highest possible timeout because they are long running jobs. That being said, it probably makes sense to consider splitting these tests up where possible so we can have much shorter runtimes for the set of tests.

Copy link
Contributor Author

@everettraven everettraven Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2963c9c does just this, splitting into logical chunks of tests for the feature, effectively reducing each job runtime to 1/3 of this previous configuration, but introduces 3 times the amount of jobs that run.

I'm not sure which approach is preferred so I'll let others chime in here.

@everettraven
Copy link
Contributor Author

Rehearsals will fail until openshift/origin#30040 is included in a payload

Comment on lines 78 to 79
- as: e2e-vsphere-external-oidc-configure
interval: 24h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to choose some jobs to cover other ARCH like multi-arch or amd64? I intended to cover it to be tracked in https://issues.redhat.com/browse/AUTH-574 . Happened to see you're adding the vsphere platform jobs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to add those in addition to the ones configured here.

I'm certainly open to it, but this PR is specifically scoped to adding the jobs required to satisfy the OCP feature promotion criteria which does not include arm64 or multi-arch jobs.

I'll do some further exploration and if it is straightforward to add arm64 and/or multi-arch jobs I'll add them. Otherwise, I'll suggest that we add those in a follow-up PR so we can continue making progress towards feature promotion.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2025
@everettraven
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

@openshift-ci-robot
Copy link
Contributor

@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@everettraven: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-authentication-operator-release-4.20-periodics-images openshift/cluster-authentication-operator presubmit Presubmit changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-vsphere-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-gcp-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-azure-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-vsphere-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-vsphere-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv6-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-azure-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv6-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv6-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-dualstack-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-dualstack-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-dualstack-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-azure-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-gcp-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-gcp-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-rollback-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-configure-techpreview N/A periodic Periodic changed
periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-uid-extra-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview 02666ad link unknown /pj-rehearse periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-metal-ovn-ipv4-external-oidc-configure-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor Author

Obsolete now. Closing.

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Aug 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

@everettraven: Closed this PR.

Details

In response to this:

Obsolete now. Closing.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants