Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jul 1, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2025

@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bentito and joelanford July 1, 2025 17:39
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2025

@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

/hold

Until we get merged : openshift/operator-framework-operator-controller#383

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

/hold

Until we get merged : openshift/operator-framework-operator-controller#383

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
@camilamacedo86
Copy link
Contributor Author

/hold

@camilamacedo86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-tests-extension

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@camilamacedo86
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-release-4.21-tests-extension

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025

@camilamacedo86: This pull request references OPRUN-3963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor

tmshort commented Jul 9, 2025

Do you need to modify the release-4.20 files, or are we considering this a part of 4.21?

@camilamacedo86
Copy link
Contributor Author

Do you need to modify the release-4.20 files, or are we considering this a part of 4.21?

It should be from 4.21 right?
I did not cherry-pick anything and I think we will not do.

My idea is to enable the CI so that when we add the tests in a follow up we start to check the changes with it already

@camilamacedo86
Copy link
Contributor Author

/hold cancel
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2025
@tmshort
Copy link
Contributor

tmshort commented Jul 9, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@tmshort
Copy link
Contributor

tmshort commented Jul 9, 2025

If we want it to be part of 4.20, you need to also update the 4.20 files; otherwise, after we branch, it this won't be enabled in 4.20.
As of right now, it's done via the main branch, and main=release-4.20, so I think you need to add it to 4.20 as well.

@camilamacedo86
Copy link
Contributor Author

@camilamacedo86
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@camilamacedo86: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-operator-framework-operator-controller-main-tests-extension openshift/operator-framework-operator-controller presubmit Presubmit changed
pull-ci-openshift-operator-framework-operator-controller-release-4.20-tests-extension openshift/operator-framework-operator-controller presubmit Presubmit changed
pull-ci-openshift-operator-framework-operator-controller-release-4.21-tests-extension openshift/operator-framework-operator-controller presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@camilamacedo86
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@camilamacedo86: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtfranz
Copy link
Contributor

dtfranz commented Jul 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dtfranz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 920dba3 into openshift:master Jul 10, 2025
18 checks passed
@camilamacedo86 camilamacedo86 deleted the ote-ci branch July 10, 2025 09:24
MrSanketkumar pushed a commit to MrSanketkumar/release that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants