Skip to content

Add more validation of step registry #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 11, 2019
Merged

Add more validation of step registry #6352

openshift-merge-robot merged 1 commit into from
Dec 11, 2019

Conversation

@AlexNPavel
Copy link
Contributor

@AlexNPavel AlexNPavel commented Dec 11, 2019

This PR adds a new presubmit that runs shellcheck on all registry commands, erroring when a warning or error level syntax issue is detected. It also expands the validate-owners.sh test to include the step registry.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@AlexNPavel AlexNPavel force-pushed the step-registry-validation branch 4 times, most recently from 8bbbda1 to 6fb6618 Compare December 11, 2019 19:31
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2019
@AlexNPavel AlexNPavel force-pushed the step-registry-validation branch 5 times, most recently from c622165 to c538287 Compare December 11, 2019 22:40
stevekuznetsov
stevekuznetsov reviewed Dec 11, 2019
View reviewed changes
@AlexNPavel AlexNPavel force-pushed the step-registry-validation branch 2 times, most recently from b573116 to bb9328f Compare December 11, 2019 23:36
@AlexNPavel AlexNPavel force-pushed the step-registry-validation branch from bb9328f to f5fb061 Compare December 11, 2019 23:46
@AlexNPavel AlexNPavel changed the title [WIP] Add more validation of step registry Add more validation of step registry Dec 11, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2019

@AlexNPavel: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/release/master/step-registry-shellcheck f5fb061 link /test pj-rehearse
ci/prow/pj-rehearse f5fb061 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexNPavel, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexNPavel,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 507d548 into openshift:master Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2019

@AlexNPavel: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-release-master-presubmits.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster default using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/artifacts/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/artifacts/artifacts/OWNERS
    • key ipi-deprovision-artifacts-artifacts-commands.sh using file ci-operator/step-registry/ipi/deprovision/artifacts/artifacts/ipi-deprovision-artifacts-artifacts-commands.sh
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/artifacts/bootstrap/OWNERS
    • key ipi-deprovision-artifacts-bootstrap-commands.sh using file ci-operator/step-registry/ipi/deprovision/artifacts/bootstrap/ipi-deprovision-artifacts-bootstrap-commands.sh
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/artifacts/must-gather/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/deprovision/deprovision/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/install/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/install/install/OWNERS
    • key OWNERS using file ci-operator/step-registry/ipi/install/rbac/OWNERS
    • key ipi-install-rbac-commands.sh using file ci-operator/step-registry/ipi/install/rbac/ipi-install-rbac-commands.sh
Details

In response to this:

This PR adds a new presubmit that runs shellcheck on all registry commands, erroring when a warning or error level syntax issue is detected. It also expands the validate-owners.sh test to include the step registry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexNPavel AlexNPavel deleted the step-registry-validation branch December 12, 2019 15:32
@wking wking mentioned this pull request Dec 12, 2019
Merged
wking added a commit to wking/openshift-release that referenced this pull request Jun 18, 2020
@wking
hack/validate-registry-commands: Drop '-S warning'
712f7d8 
The previous warning limit landed with the script in f5fb061 (Add
more validation of step registry, 2019-12-11, openshift#6352), but complaining
about info- and style-level issues too will improve uniformity and
code quality.
@wking wking mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexNPavel @openshift-ci-robot @stevekuznetsov @openshift-merge-robot