Skip to content

OCPBUGS-53003: rename 'master' to 'main' for cluster-api-provider-aws#62705

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
DennisPeriquet:OCPBUGS-53003_cluster-api-provider-aws_master-1
May 13, 2025
Merged

OCPBUGS-53003: rename 'master' to 'main' for cluster-api-provider-aws#62705
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
DennisPeriquet:OCPBUGS-53003_cluster-api-provider-aws_master-1

Conversation

@DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Mar 12, 2025

This PR is in support of renaming the default branch for https://github.com/openshift/cluster-api-provider-aws from 'master' to 'main'.

Unhold this PR only when:

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 12, 2025

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-53003, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/cluster-api-provider-aws from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from 31ddb75 to cf4134f Compare March 25, 2025 20:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch 2 times, most recently from 8c216e5 to ad722dd Compare April 3, 2025 19:52
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from ad722dd to dec05ce Compare April 7, 2025 15:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from dec05ce to adf245e Compare April 7, 2025 18:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 8, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from adf245e to efa848f Compare April 23, 2025 17:39
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 23, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from efa848f to e309e34 Compare April 29, 2025 13:50
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from e309e34 to 67d8782 Compare May 12, 2025 13:31
This was referenced May 12, 2025
Merged
Merged
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from 67d8782 to 149cb29 Compare May 13, 2025 14:42
@DennisPeriquet
Copy link
Contributor Author

DennisPeriquet commented May 13, 2025

/pj-rehearse pull-ci-openshift-cluster-api-provider-aws-main-images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jupierce
Copy link
Contributor

jupierce commented May 13, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2025
@DennisPeriquet
Copy link
Contributor Author

DennisPeriquet commented May 13, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-53003_cluster-api-provider-aws_master-1 branch from 149cb29 to b60c00c Compare May 13, 2025 17:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

[REHEARSALNOTIFIER]
@DennisPeriquet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-capi-techpreview openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-ovn openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-ovn-techpreview openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-serial-1of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-aws-serial-2of2 openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-e2e-hypershift openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-images openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-okd-scos-e2e-aws-ovn openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-okd-scos-images openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-regression-clusterinfra-aws-ipi-proxy-techpreview openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-security openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-unit openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-verify-commits openshift/cluster-api-provider-aws presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-aws-main-verify-deps openshift/cluster-api-provider-aws presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jupierce
Copy link
Contributor

jupierce commented May 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DennisPeriquet
Copy link
Contributor Author

DennisPeriquet commented May 13, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c1ccc0a into openshift:master May 13, 2025
5 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2025

@DennisPeriquet: Jira Issue OCPBUGS-53003: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-53003 has not been moved to the MODIFIED state.

Details

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/cluster-api-provider-aws from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
@DennisPeriquet @tbuskey
OCPBUGS-53003: rename 'master' to 'main' for cluster-api-provider-aws (…
cc786b8 
…openshift#62705)

* OCPBUGS-53003: rename 'master' to 'main' for cluster-api-provider-aws

* OCPBUGS-53003: run 'make jobs'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@enxebre enxebre Awaiting requested review from enxebre

@pruan-rht pruan-rht Awaiting requested review from pruan-rht

Assignees

@jupierce jupierce

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DennisPeriquet @openshift-ci-robot @jupierce @openshift-merge-robot