Skip to content

installer: save AWS instance output as text in teardown #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 2 commits into from
Closed

installer: save AWS instance output as text in teardown #6252

vrutkovs wants to merge 2 commits into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Dec 5, 2019 •
edited
Loading

Instead of saving a full json artifacts should contain plain text.

See
https://docs.aws.amazon.com/cli/latest/reference/ec2/get-console-output.html#examples

However atm this would save an empty file for some weird reason

/cc @wking

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 5, 2019

/retest

@vrutkovs vrutkovs force-pushed the aws-instance-output-text branch from 692c04f to f998498 Compare December 5, 2019 14:48
@vrutkovs vrutkovs mentioned this pull request Dec 5, 2019
Merged
@vrutkovs vrutkovs force-pushed the aws-instance-output-text branch from f998498 to aaca099 Compare December 5, 2019 15:12
@wking
Copy link
Member

wking commented Dec 5, 2019

Try touching something meaningless in a 4.2->4.3 update job definition to trigger a rehearsal that shows a broken machine reboot.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the aws-instance-output-text branch from 291bfff to f5f5fa7 Compare December 5, 2019 17:50
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Dec 5, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2019

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-4.2-to-4.3 f5f5fa7 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp f5f5fa7 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-azure f5f5fa7 link /test pj-rehearse
ci/prow/pj-rehearse f5f5fa7 link /test pj-rehearse
ci/prow/step-registry-shellcheck f5f5fa7 link /test step-registry-shellcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 4, 2020

Implemented in 6ec5bf3

@vrutkovs vrutkovs closed this Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @wking @openshift-ci-robot